Bug 268142

Summary: [NEW PORT] sysutils/amazon-ssm-plugin: Amazon AWS SSM Session Manager Plugin for AWSCLi
Product: Ports & Packages Reporter: Norikatsu Shigemura <nork>
Component: Individual Port(s)Assignee: Mikael Urankar <mikael>
Status: Closed FIXED    
Severity: Affects Some People CC: meta, mikael
Priority: --- Keywords: needs-patch
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/aws/session-manager-plugin/
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264919
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258879
Attachments:
Description Flags
patch
none
git-format-patch
nork: maintainer-approval+
new patch for 1.2.398.0
nork: maintainer-approval+
latest patch nork: maintainer-approval+

Description Norikatsu Shigemura 2022-12-03 22:22:55 UTC
Created attachment 238504 [details]
patch

Add a new port for amazon-ssm-plugin-1.2.398.0, a Amazon AWS SSM Session Manager Plugin for AWSCLi.

It's useful following case on FreeBSD:
  aws ssm start-session --target "your instance-id"

This awscli's plugin provides login to instances in AWS isolated network(in private, firewalled and/or no global IPs) and SSH forwarding function.

SEE ALSO: https://docs.aws.amazon.com/systems-manager/latest/userguide/session-manager-working-with-install-plugin.html
Comment 1 Koichiro Iwao freebsd_committer freebsd_triage 2022-12-05 03:02:41 UTC
Could you commit it to your local git repository and attach the patch generated by 'git format-patch'?  It is easier for developers to apply.
Comment 2 Norikatsu Shigemura 2022-12-09 02:56:52 UTC
Created attachment 238656 [details]
git-format-patch

Hi,
>Could you commit it to your local git repository and attach the patch generated by 'git format-patch'?  It is easier for developers to apply.

Is this patch OK?
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2023-01-15 13:35:22 UTC
It doesn't build:
sysutils/amazon-ssm-plugin has dependency on devel/py-awscli with invalid empty FLAVOR; Please contact maintainer of the port to fix this.
Comment 4 Norikatsu Shigemura 2023-01-16 04:24:55 UTC
Created attachment 239498 [details]
new patch for 1.2.398.0

> sysutils/amazon-ssm-plugin has dependency on devel/py-awscli with invalid empty FLAVOR; 

Oops sorry, I fixed this issue, and update/adopt to 1.2.398.0.
Please test new attached patch.
Comment 5 Mikael Urankar freebsd_committer freebsd_triage 2023-01-16 16:52:08 UTC
(In reply to Norikatsu Shigemura from comment #4)
same error as before:
[00:00:01] Error: sysutils/amazon-ssm-plugin has dependency on devel/py-awscli with invalid empty FLAVOR; Please contact maintainer of the port to fix this.
Comment 6 Norikatsu Shigemura 2023-01-17 00:40:27 UTC
Created attachment 239521 [details]
latest patch

> same error as before:
> [00:00:01] Error: sysutils/amazon-ssm-plugin has dependency on devel/py-awscli with invalid empty FLAVOR; Please contact maintainer of the port to fix this.

Humm..., I researched this behavior, so I knew to use "USES=python:env" in this case.

* UESE=go
# make -VRUN_DEPENDS
aws:devel/py-awscli@

* UESE=go python:env
# make -VRUN_DEPENDS
aws:devel/py-awscli@py310

So I attached a new latest patch, please check it.
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-01-17 17:07:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b3cf3d7a458712063e30e35c45b2adf886010656

commit b3cf3d7a458712063e30e35c45b2adf886010656
Author:     Norikatsu Shigemura <nork@ninth-nine.com>
AuthorDate: 2023-01-17 17:05:01 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2023-01-17 17:07:19 +0000

    sysutils/amazon-ssm-plugin: Add new port

    This package provides Amazon SSM SessionManager and CLI for managing
    shell experience using SSM APIs.

    PR:             268142

 sysutils/Makefile                                  |  1 +
 sysutils/amazon-ssm-plugin/Makefile (new)          | 57 ++++++++++++++++++++++
 sysutils/amazon-ssm-plugin/distinfo (new)          |  3 ++
 .../files/patch-seelog__unix.xml (new)             | 14 ++++++
 .../files/patch-src_log_log__unix.go (new)         | 22 +++++++++
 .../files/patch-src_version_version.go (new)       |  8 +++
 sysutils/amazon-ssm-plugin/pkg-descr (new)         |  7 +++
 7 files changed, 112 insertions(+)
Comment 8 Mikael Urankar freebsd_committer freebsd_triage 2023-01-17 17:09:33 UTC
I have fixed PLIST_FILES

You should use poudriere to catch these problems.