Bug 268342
| Summary: | devel/py-pyls-black 0.4.7 requires python-language-server | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | p5B2EA84B3 |
| Component: | Individual Port(s) | Assignee: | Rainer Hurling <rhurlin> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | rhurlin, vishwin |
| Priority: | --- | Flags: | rhurlin:
maintainer-feedback+
|
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
p5B2EA84B3
2022-12-12 22:54:37 UTC
Sorry for the long delay, I was way too busy :( And thanks for the report. Yes, this is definitely wrong, because the name of the port has changed from py-python-language-server to py-python-lsp-server, see entry from 2021-08-01 in MOVED. While I'm patching this, I'd like to make a few more additions to the port, hopefully including working tests ;) Most importantly, I'd like to wait for a change for Mk/Uses/python.mk that introduces PEP-517 so that pyproject.toml can be used for configuration. This may take a few more days ... A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4b0bcfb68e9f96e3ace2f359ef99a539b229ee13 commit 4b0bcfb68e9f96e3ace2f359ef99a539b229ee13 Author: Rainer Hurling <rhurlin@FreeBSD.org> AuthorDate: 2023-01-14 08:16:28 +0000 Commit: Rainer Hurling <rhurlin@FreeBSD.org> CommitDate: 2023-01-14 08:16:28 +0000 devel/py-pyls-black: Use python-lsp-server Conversion from python-language-server (deprecated) to python-lsp-server by cherry picking from Github[1][2]. No conversion to PEP517, since 2023Q1 does not contain it. This will be done in a follow up commit. [1] https://github.com/rupert/pyls-black/pull/37 [2] https://github.com/rupert/pyls-black/pull/41 PR: 268342 Reported by: p5B2EA84B3@t-online.de MFH: 2023Q1 devel/py-pyls-black/Makefile | 2 ++ devel/py-pyls-black/files/patch-README.md (new) | 14 ++++++++ .../files/patch-pyls__black_plugin.py (new) | 41 ++++++++++++++++++++++ devel/py-pyls-black/files/patch-setup.cfg (new) | 11 ++++++ 4 files changed, 68 insertions(+) A commit in branch 2023Q1 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=abc7dd2d594e2537238a5344bf186d286ce219de commit abc7dd2d594e2537238a5344bf186d286ce219de Author: Rainer Hurling <rhurlin@FreeBSD.org> AuthorDate: 2023-01-14 08:16:28 +0000 Commit: Rainer Hurling <rhurlin@FreeBSD.org> CommitDate: 2023-01-14 08:28:25 +0000 devel/py-pyls-black: Use python-lsp-server Conversion from python-language-server (deprecated) to python-lsp-server by cherry picking from Github[1][2]. No conversion to PEP517, since 2023Q1 does not contain it. This will be done in a follow up commit. [1] https://github.com/rupert/pyls-black/pull/37 [2] https://github.com/rupert/pyls-black/pull/41 PR: 268342 Reported by: p5B2EA84B3@t-online.de MFH: 2023Q1 (cherry picked from commit 4b0bcfb68e9f96e3ace2f359ef99a539b229ee13) devel/py-pyls-black/Makefile | 2 ++ devel/py-pyls-black/files/patch-README.md (new) | 14 ++++++++ .../files/patch-pyls__black_plugin.py (new) | 41 ++++++++++++++++++++++ devel/py-pyls-black/files/patch-setup.cfg (new) | 11 ++++++ 4 files changed, 68 insertions(+) Sorry it took so long. There were already corresponding patches on Github, but I wanted to send them through the test routines of the project. However, it was necessary to wait for the conversion of the FreeBSD Python framework to PEP517, since the test routines are based on it. Please try when you get a chance if everything works as expected, thanks. Unfortunately building py39-pyls-black-0.4.7_2 fails: =======================<phase: build >============================ ===== env: NO_DEPENDS=yes USER=root UID=0 GID=0 ===> Building for py39-pyls-black-0.4.7_2 * Getting build dependencies for wheel... running egg_info writing pyls_black.egg-info/PKG-INFO writing dependency_links to pyls_black.egg-info/dependency_links.txt writing entry points to pyls_black.egg-info/entry_points.txt writing requirements to pyls_black.egg-info/requires.txt writing top-level names to pyls_black.egg-info/top_level.txt reading manifest file 'pyls_black.egg-info/SOURCES.txt' adding license file 'LICENSE' writing manifest file 'pyls_black.egg-info/SOURCES.txt' ERROR Missing dependencies: wheel *** Error code 1 Stop. make: stopped in /usr/ports/devel/py-pyls-black =>> Cleaning up wrkdir ===> Cleaning for py39-pyls-black-0.4.7_2 build of devel/py-pyls-black@py39 | py39-pyls-black-0.4.7_2 ended at Sat Jan 14 12:44:34 CET 2023 build time: 00:00:07 !!! build failure encountered !!! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e77b093ffd18cc07891e8d6c427dd510006820a6 commit e77b093ffd18cc07891e8d6c427dd510006820a6 Author: Rainer Hurling <rhurlin@FreeBSD.org> AuthorDate: 2023-01-14 13:17:36 +0000 Commit: Rainer Hurling <rhurlin@FreeBSD.org> CommitDate: 2023-01-14 13:17:36 +0000 devel/py-pyls-black: Add wheel build dependency Forgot to add wheel as dependency, pyproject.toml isn't helpfull here. PR: 268342 Reported by: p5B2EA84B3@t-online.de devel/py-pyls-black/Makefile | 1 + 1 file changed, 1 insertion(+) Oops, forgot to add py-wheel. Thanks for reporing. Just committed, please try again. The presence of setup.cfg (and setup.py) means that the build backend here is setuptools. wheel is not listed anywhere in setup.cfg, and this build only happens to succeed because setuptools is a (currently) transitive dependency of wheel. (In reply to Charlie Li from comment #8) That sounds reasonable, thanks for explanation. But if I follow your advice and add BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}setuptools>0:devel/py-setuptools@${PY_FLAVOR} I get the same error as reported in comment #5 (missing wheel dependency). Any idea? Per PEP-518, the default [build-system] section when not defined is: [build-system] # Minimum requirements for the build system to execute. requires = ["setuptools", "wheel"] # PEP 508 specifications. So both setuptools and wheel need to be in BUILD_DEPENDS. There is a possibility that the dependency tree between those two may reverse in the future, so better to be explicit. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7980492d7561fed0305bbbd7e432b879b2aee21e commit 7980492d7561fed0305bbbd7e432b879b2aee21e Author: Rainer Hurling <rhurlin@FreeBSD.org> AuthorDate: 2023-01-15 17:44:17 +0000 Commit: Rainer Hurling <rhurlin@FreeBSD.org> CommitDate: 2023-01-15 17:44:17 +0000 devel/py-pyls-black: Make build system PEP-518 conform Thanks to Charlie Li for clarifying the build system dependencies. PR: 268342 Reported by: vishwin devel/py-pyls-black/Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) |
