Bug 268427

Summary:	porters-handbook/versions: Fix table rendering
Product:	Documentation	Reporter:	Juraj Lutter <otis>
Component:	Books & Articles	Assignee:	Danilo G. Baio <dbaio>
Status:	Closed FIXED
Severity:	Affects Many People	CC:	dbaio, grahamperrin, re
Priority:	---
Version:	Latest
Hardware:	Any
OS:	Any
See Also:	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268425

Description Juraj Lutter freebsd_committer

2022-12-17 09:58:44 UTC

There seems to be unprocessed entries below version 1301507.

...
|1301510 |6820a0512fa6 |December 8, 2022 |13.1-STABLE after LinuxKPI dmi_matches() fixes.

//// Template:

13XXXXX

XXXXXXXX

October 30, 2021

13.0-STABLE after XXXXXX. ////

== FreeBSD 12 Versions

.FreeBSD 12 __FreeBSD_version Values [cols="1,1,1,1", frame="none", options="header"]

| Value | Revision | Date | Release

|1200000 |302409 |July 7, 2016 |12.0-CURRENT.
...

Comment 1 Graham Perrin freebsd_committer

2022-12-17 10:42:58 UTC

<https://docs.freebsd.org/en/books/porters-handbook/versions/#versions-13> 
followed by: 

<https://docs.freebsd.org/en/books/porters-handbook/versions/#versions-12> | 
<https://github.com/freebsd/freebsd-doc/blob/main/documentation/content/en/books/porters-handbook/versions/_index.adoc#versions-12>

At a glance, the problems _might_ be around the area for 12: 

* 'FreeBSD 12 Versions' missing from the table of contents, and so on. 

Document history in GitHub: 

* <https://github.com/freebsd/freebsd-doc/commits/main/documentation/content/en/books/porters-handbook/versions/_index.adoc>

If <https://github.com/freebsd/freebsd-doc/blob/bc38e8b421f9e300ac7598a3650f3066f650e840/documentation/content/en/books/porters-handbook/versions/_index.adoc> (2022-10-20) appears OK, then I'm confused, because I see nothing wrong with subsequent <https://github.com/freebsd/freebsd-doc/commit/14251d3c623b83c686b1b24fbd1dd5c89950c4a8> (2022-12-08): 

> Document __FreeBSD_version 1301510. 

re@ am I missing something?

Comment 2 commit-hook freebsd_committer

2022-12-17 11:29:48 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/doc/commit/?id=ee220271f90d3f9e6ff18ee0b31c8434246feca2

commit ee220271f90d3f9e6ff18ee0b31c8434246feca2
Author:     Danilo G. Baio <dbaio@FreeBSD.org>
AuthorDate: 2022-12-17 11:25:54 +0000
Commit:     Danilo G. Baio <dbaio@FreeBSD.org>
CommitDate: 2022-12-17 11:25:54 +0000

    porters-handbook/versions: Fix table rendering

    While here, add a new line before the end of the table; it's a common
    issue to add the end of the table markup when adding a new version
    entry.

    PR:             268427 [1]
    Reported by:    otis[1] pauamma (IRC)

 documentation/content/en/books/porters-handbook/versions/_index.adoc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comment 3 Danilo G. Baio freebsd_committer

2022-12-17 11:38:40 UTC

Thanks for reporting.

Comment 4 Graham Perrin freebsd_committer

2022-12-17 11:41:23 UTC

(In reply to Danilo G. Baio from comment #3)

Thanks! I think I see it now (split), 

<https://github.com/freebsd/freebsd-doc/commit/ee220271f90d3f9e6ff18ee0b31c8434246feca2?diff=split#diff-5b45b8935e883e1f10e2a44318871e8be82e810be90a08b03b893f5a06ee51b3L1304> line 1304