Bug 268758

Summary: x11-wm/hikari: input from mouse/keyboard goes to wrong view
Product: Ports & Packages Reporter: J.R. Oldroyd <fbsd>
Component: Individual Port(s)Assignee: Ashish SHUKLA <ashish>
Status: Closed FIXED    
Severity: Affects Some People Flags: bugzilla: maintainer-feedback? (ashish)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch to fix problem of mouse/keyboard input going to wrong view none

Description J.R. Oldroyd 2023-01-05 02:48:06 UTC 
Created attachment 239270 [details]
patch to fix problem of mouse/keyboard input going to wrong view

A patch provided at [1] fixes a bug in hikari that causes mouse and keyboard input to go to the wrong view.

Attached is a patch to the FreeBSD port.

A repeat-by is as follows:

1. start hikari
2. start several applications, such as a mail reader (e.g., claws-mail) and browser (e.g., firefox)
3. arrange that these are on separate hikari sheets

You'll see that all mouse and keyboard input goes to one of the two apps (usually the browser for me).  It is impossible to use the other app.

The one-line patch fixes it.

[1]  https://hub.darcs.net/holycow/hikari/patch/de3817572a6c3ba5b51614fe31151d2c63fe1fd4#src/xwayland_view.c
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-01-15 16:14:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=50fe17b00a7d36abf86931f1ed32046479025741

commit 50fe17b00a7d36abf86931f1ed32046479025741
Author:     Ashish SHUKLA <ashish@FreeBSD.org>
AuthorDate: 2023-01-15 15:44:35 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2023-01-15 16:13:52 +0000

    x11-wm/hikari: Fix a bug

    - Add a patch where input from mouse/keyboard goes to the wrong view

    PR:             268758
    Reported by:    J.R. Oldroyd <fbsd at opal dot com>

 x11-wm/hikari/Makefile                               |  2 +-
 x11-wm/hikari/files/patch-Makefile                   |  4 ++--
 x11-wm/hikari/files/patch-src_xwayland__view.c (new) | 10 ++++++++++
 3 files changed, 13 insertions(+), 3 deletions(-)
Comment 2 Ashish SHUKLA freebsd_committer freebsd_triage 2023-01-15 16:14:31 UTC 
Committed, thanks!