Bug 268815

Summary: japanese/kakasi: fix build with clang 15
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: Dimitry Andric <dim>
Status: Closed FIXED    
Severity: Affects Some People CC: fernape, ota
Priority: --- Flags: bugzilla: maintainer-feedback? (ota)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 265425    
Attachments:
Description Flags
japanese/kakasi: fix build with clang 15 none

Description Dimitry Andric freebsd_committer freebsd_triage 2023-01-07 15:56:20 UTC 
During an exp-run for llvm 15 (see bug 265425), it turned out that japanese/kakasi failed to build with clang 15:

  kanjiio.c:1083:11: error: incompatible integer to pointer conversion assigning to 'iconv_t' (aka 'struct __tag_iconv_t *') from 'int' [-Wint-conversion]
          fromutf8 = -1;
                   ^ ~~
  kanjiio.c:1087:9: error: incompatible integer to pointer conversion assigning to 'iconv_t' (aka 'struct __tag_iconv_t *') from 'int' [-Wint-conversion]
          toutf8 = -1;
                 ^ ~~

This is because 'fromutf8' and 'toutf8' are of pointer type, not int. Add a cast to silence the warning.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2023-01-07 15:56:42 UTC 
Created attachment 239333 [details]
japanese/kakasi: fix build with clang 15
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-01-07 16:39:01 UTC 
^Triage: reporter is committer, assign accordingly.
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-01-16 19:06:18 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bb59375ae0ea035a780aabd0259f352c09b23ed9

commit bb59375ae0ea035a780aabd0259f352c09b23ed9
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-01-07 15:53:53 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-01-16 19:04:47 +0000

    japanese/kakasi: fix build with clang 15

    During an exp-run for llvm 15 (see bug 265425), it turned out that
    japanese/kakasi failed to build with clang 15:

      kanjiio.c:1083:11: error: incompatible integer to pointer conversion assigning to 'iconv_t' (aka 'struct __tag_iconv_t *') from 'int' [-Wint-conversion]
              fromutf8 = -1;
                       ^ ~~
      kanjiio.c:1087:9: error: incompatible integer to pointer conversion assigning to 'iconv_t' (aka 'struct __tag_iconv_t *') from 'int' [-Wint-conversion]
              toutf8 = -1;
                     ^ ~~

    This is because 'fromutf8' and 'toutf8' are of pointer type, not int.
    Add a cast to silence the warning.

    PR:             268815
    Approved by:    portmgr (tcberner)
    MFH:            2023Q1

 japanese/kakasi/files/patch-src_kanjiio.c (new) | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)