Bug 268916

Comment 1 Ashish SHUKLA 2023-01-15 15:57:44 UTC

Thanks for letting me know.

I'll test it, and assuming it works, when 1.0.0 comes out, I'll update it.

(In reply to Ashish SHUKLA from comment #1)

> I'll test it, and assuming it works, when 1.0.0 comes out, I'll update it.

Why wait for 1.0.0 to come out? The current package doesn't work. Shouldn't it be marked broken instead of waiting for 1.0.0?

Comment 3 Ashish SHUKLA 2023-01-20 21:45:12 UTC

(In reply to Ashish SHUKLA from comment #1)

It doesn't work for me with locally updated rc1 port[0].

Could you share details about your setup ? And if you've a local updated copy of port, or diff to update the port (in case I'm something is amiss in mine), then please share.

(In reply to Yonas Yanfa from comment #2)

> Why wait for 1.0.0 to come out? The current package doesn't work. Shouldn't it be marked broken instead of waiting for 1.0.0?

I didn't realize I could do that. I'll mark it as BROKEN later today.
 
References:
[0] https://people.freebsd.org/~ashish/meilisearch-20220121-0.tar

Thanks!

Comment 4 commit-hook 2023-01-22 18:46:46 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e0e169f3a18fa13d173f5572f27551e9cbca040c

commit e0e169f3a18fa13d173f5572f27551e9cbca040c
Author:     Ashish SHUKLA <ashish@FreeBSD.org>
AuthorDate: 2023-01-22 18:43:29 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2023-01-22 18:43:29 +0000

    textproc/meilisearch: Mark as BROKEN

    PR:             268916
    Reported by:    Yonas Yanfa <yonas dot yanfa at gmail dot com>

 textproc/meilisearch/Makefile | 2 ++
 1 file changed, 2 insertions(+)

(In reply to Ashish SHUKLA from comment #3)

> Could you share details about your setup ?

I'm running 13.1-RELEASE-p5.

> And if you've a local updated copy of port, or diff to update the port

No I don't. I built it from a git checkout.

(In reply to Ashish SHUKLA from comment #1)

v1.0.0 is out.

https://blog.meilisearch.com/v1-enterprise-ready-stable/

Created attachment 240409 [details]
Port directory updated to v1.0.2

I prepared an update to meilisearch-1.0.2
After a few basic checks it seems to work as expected.

Comment 8 commit-hook 2023-02-26 12:33:51 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fa8d957963518c250bed6e302754ff5996b917ab

commit fa8d957963518c250bed6e302754ff5996b917ab
Author:     Vladyslav Movchan <vladislav.movchan@gmail.com>
AuthorDate: 2023-02-26 12:27:39 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2023-02-26 12:31:59 +0000

    textproc/meilisearch: Update to 1.0.2

    - Unbreak
    - Use the embedded liblmdb to be more close to upstream
    - Embed VCS information in the binary

    PR:             268916
    Co-authored-by: Ashish SHUKLA <ashish@FreeBSD.org>

 textproc/meilisearch/Makefile                      |  559 +++++-----
 textproc/meilisearch/distinfo                      | 1080 ++++++++++----------
 ...4372697ea991fe2a4cae3b_lmdb-sys_build.rs (gone) |   11 -
 ...go-crates_lindera-ipadic-0.12.6_build.rs (gone) |   47 -
 ...rgo-crates_lindera-ipadic-0.17.0_build.rs (new) |   36 +
 .../files/patch-meilisearch-http_build.rs (gone)   |   26 -
 .../files/patch-meilisearch_build.rs (new)         |   37 +
 7 files changed, 905 insertions(+), 891 deletions(-)

Comment 9 Ashish SHUKLA 2023-02-26 12:37:00 UTC

(In reply to Vladyslav Movchan from comment #7)


Thanks, that worked perfectly.

For next time, could you please submit changes in a diff, as they're easier to review that way.

Thanks again!

(In reply to Ashish SHUKLA from comment #9)
Thanks a lot!
I'll provide a diff next time to make it easier to review.