Summary: | [New port] devel/ptl: Lightweight C++11 multithreading tasking system | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Erik Jensen <erik> | ||||||
Component: | Individual Port(s) | Assignee: | Fernando Apesteguía <fernape> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | fernape, grahamperrin | ||||||
Priority: | --- | ||||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
URL: | https://github.com/jrmadsen/PTL | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 268993 | ||||||||
Attachments: |
|
Port passed a `poudriere testport` on 12.3R, 12.4R and 13.1R amd64 on my system. Hi Erik, There are quite a few issues. From portlint: WARN: Makefile: [15]: USE_* seen before USES. According to the porters-handbook, USES must appear first. WARN: /data/fernape_data/FreeBSD-repos/ports/devel/ptl/pkg-descr: contains less than 2 lines, make it longer if possible.(currently 1 line) WARN: /data/fernape_data/FreeBSD-repos/ports/devel/ptl/pkg-descr: includes lines that exceed 80 characters. FATAL: Makefile: [1]: use a tab (not space) after a variable name FATAL: Makefile: [2]: use a tab (not space) after a variable name FATAL: Makefile: [3]: use a tab (not space) after a variable name FATAL: Makefile: [4]: use a tab (not space) after a variable name FATAL: Makefile: [6]: use a tab (not space) after a variable name FATAL: Makefile: [7]: use a tab (not space) after a variable name FATAL: Makefile: [8]: use a tab (not space) after a variable name FATAL: Makefile: [10]: use a tab (not space) after a variable name FATAL: Makefile: [11]: use a tab (not space) after a variable name FATAL: Makefile: [13]: use a tab (not space) after a variable name FATAL: Makefile: [15]: use a tab (not space) after a variable name FATAL: Makefile: [16]: use a tab (not space) after a variable name FATAL: Makefile: [17]: use a tab (not space) after a variable name FATAL: Makefile: [19]: use a tab (not space) after a variable name FATAL: Makefile: [21]: use a tab (not space) after a variable name WARN: Makefile: [23]: use a tab (not space) after a variable name WARN: Makefile: [24]: use tab (not space) to make indentation WARN: Makefile: "USES" has to appear earlier. # USES block +USES USE_GITHUB GH_ACCOUNT GH_PROJECT -USES Would you mind reordering "USES", replacing the tabs and probably cutting the pkg-descr line into two lines? Thanks! Created attachment 241086 [details]
git diff --staged of new port - fixed Makefile
I attach a new patch here.
I was unaware of the existence of portlint when I submitted the previous patch, but I have started using it actively in the meantime.
Thanks!
Committed, Thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6e66e8aa832e22ec7bf21dd9dea8439023f224e0 commit 6e66e8aa832e22ec7bf21dd9dea8439023f224e0 Author: Erik Jensen <erik@tenku.dk> AuthorDate: 2023-03-26 17:51:25 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2023-03-27 09:59:28 +0000 devel/ptl: new port. Lightweight C++11 multithreading tasking system Parallel Tasking Library is a needed dependency for the upcoming update of science/geant4. ChangeLog: https://github.com/jrmadsen/PTL PR: 268992 Reported by: erik@tenku.dk devel/Makefile | 1 + devel/ptl/Makefile (new) | 25 +++++++++++++++++++++++++ devel/ptl/distinfo (new) | 3 +++ devel/ptl/pkg-descr (new) | 2 ++ devel/ptl/pkg-plist (new) | 35 +++++++++++++++++++++++++++++++++++ 5 files changed, 66 insertions(+) |
Created attachment 239512 [details] git diff --staged of new port Propose to add PTL (Parallel Tasking Library) to ports tree