Bug 269003

Summary: www/py-woob: do not install test files
Product: Ports & Packages Reporter: Oleg Sidorkin <osidorkin>
Component: Individual Port(s)Assignee: Jason E. Hale <jhale>
Status: Closed FIXED    
Severity: Affects Only Me Flags: jhale: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269029
Attachments:
Description Flags
patch to skip www/py-woob test files installation (to apply via git am) jhale: maintainer-approval+

Description Oleg Sidorkin 2023-01-17 10:42:29 UTC
Created attachment 239532 [details]
patch to skip www/py-woob test files installation (to apply via git am)

Attached patch adds test and test.* modules to exclude list.
It prevents test files from being installed.

This fixes conflict between www/py-woob and e.g. www/py-cachecontrol due to .../site-packages/tests/__init__.py.
Comment 1 Jason E. Hale freebsd_committer freebsd_triage 2023-01-17 20:50:41 UTC
Thanks. It looks like upstream moved tests into a separate directory and likely forgot to exclude them in the latest release. www/py-cachecontrol should probably not be installing tests either. The unfortunate side effect of autoplist is I don't tend to catch these sort of things.
Comment 2 Oleg Sidorkin 2023-01-17 20:57:28 UTC
(In reply to Jason E. Hale from comment #1)
Yep. Going to create another ticket tomorrow
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-01-17 21:02:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bbbaebcf3bce14d6e320a086345351ed0718305c

commit bbbaebcf3bce14d6e320a086345351ed0718305c
Author:     Oleg Sidorkin <osidorkin@gmail.com>
AuthorDate: 2023-01-16 19:34:14 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2023-01-17 20:58:31 +0000

    www/py-woob: Do not install tests files

    PR:             269003

 www/py-woob/Makefile                   |  1 +
 www/py-woob/files/patch-setup.py (new) | 14 ++++++++++++++
 2 files changed, 15 insertions(+)
Comment 4 Jason E. Hale freebsd_committer freebsd_triage 2023-01-17 21:04:25 UTC
Cool! Fixed on this end anyways.