Bug 269022

Summary: net-mgmt/cacti: add missing dependencies
Product: Ports & Packages Reporter: David Siebörger <drs-freebsd>
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Only Me CC: fuz, m.muenz
Priority: --- Flags: m.muenz: maintainer-feedback+
fuz: merge-quarterly-
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 271440    
Attachments:
Description Flags
Add dependencies on intl and pcntl PHP modules
fuz: maintainer-approval+
Poudriere build log none

Description David Siebörger 2023-01-18 06:43:58 UTC 
Created attachment 239552 [details]
Add dependencies on intl and pcntl PHP modules

In version 1.2.23, Cacti's installer checks for the presence of the intl and pcntl PHP modules:

https://github.com/Cacti/cacti/commit/27308d840cc994997c767ca412385b13975608b4
https://github.com/Cacti/cacti/commit/15cdd4a55e6c635ce04d76ec10ddc8fe4db5d50b

Thus the port ought to depend on those modules.  The attached patch adds those dependencies.
Comment 1 David Siebörger 2023-01-18 06:45:00 UTC 
Created attachment 239553 [details]
Poudriere build log
Comment 2 Michael Muenz 2023-01-19 12:39:21 UTC 
Looks good, thanks! 
What makes me wonder is, that with php80 json is already included but the installer of cacti tells me php-json is missing. Do you have this error too?
Comment 3 David Siebörger 2023-01-20 06:09:23 UTC 
(In reply to Michael Muenz from comment #2)

I haven't had the issue with json.  Here, the installer was only complaining about intl and pcntl.  We're running PHP 8.1, if that makes a difference.
Comment 4 Michael Muenz 2023-01-20 14:55:02 UTC 
Had a broken update from 74 to 81, now it works for me too.
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-04-28 09:36:25 UTC 
Comment on attachment 239552 [details]
Add dependencies on intl and pcntl PHP modules

Do you approve of this patch?  If yes, please set maintainer-approval to "+".
Comment 6 Michael Muenz 2023-05-16 14:49:39 UTC 
Sorry for the delay, I approved the patch
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2023-05-16 14:54:44 UTC 
Comment on attachment 239552 [details]
Add dependencies on intl and pcntl PHP modules

Maintainer approval has been granted.
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2023-05-16 15:02:36 UTC 
Will commit with light adaptions following commit 0ac3a695.

Dear maintainer, would you like this update to be MFH'ed into the 2023Q2 branch?
Comment 9 commit-hook freebsd_committer freebsd_triage 2023-05-18 08:21:12 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bc6e8c0e283fcec28796a874d6280a2081bc801d

commit bc6e8c0e283fcec28796a874d6280a2081bc801d
Author:     David Siebörger <drs-freebsd@sieborger.nom.za>
AuthorDate: 2023-05-16 14:59:11 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-05-18 08:19:47 +0000

    net-mgmt/cacti: USE_PHP+= intl pcntl

    In version 1.2.23, Cacti's installer checks for the presence of the intl
    and pcntl PHP modules.  Thus the port ought to depend on those modules.

    Also switch to DISTVERSION while we are at it.

    See also:       https://github.com/Cacti/cacti/commit/27308d84
    See also:       https://github.com/Cacti/cacti/commit/15cdd4a5
    PR:             269022
    Approved by:    m.muenz@gmail.com (maintainer)

 net-mgmt/cacti/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 10 Robert Clausecker freebsd_committer freebsd_triage 2023-05-18 08:27:20 UTC 
Thank you for your submission.
Comment 11 Robert Clausecker freebsd_committer freebsd_triage 2023-05-18 08:27:49 UTC 
Not MFH'ed due to a lack of maintainer response.