Bug 269031

Summary: devel/popt: Backport patches for conversion to CMake
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (sunpoet)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for popt
none
Patch for popt v2
none
Patch for popt v3 none

Description Daniel Engberg freebsd_committer freebsd_triage 2023-01-18 16:46:11 UTC 
Created attachment 239560 [details]
Patch for popt

As with many other projects upstream is moving away from GNU Autotools, backport patches for switching to CMake so other ports can utilize CMake package files.

* Switch to CMake as upstream no longer supports GNU Autotools [1]
* Backport upstream patches for CMake conversion [2]
* Backport patch to fix tests [3]
* Remove USES= iconv, port uses iconv in libc
* Rework port to follow Porters Handbook more closely

Compile and runtime tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist, make test)
Poudriere testport OK 12.3-RELEASE (amd64)
Poudriere testport OK 13.1-RELEASE (i386)

References:

[1] https://github.com/rpm-software-management/popt/commit/e145ea481570a42b2617f5c4be1ada1aaacf6026 

[2]
https://github.com/rpm-software-management/popt/commit/692ae48f58a659015b38bdf20d8279d87fc9b0b0
https://github.com/rpm-software-management/popt/commit/0788cb2c5e8b606a7c4e6e0b77cbfb8c55e42e2a
https://github.com/rpm-software-management/popt/commit/975cf4b143d5287c9c9a8e8e9c5f1554b79cb255

[3]
https://github.com/rpm-software-management/popt/commit/ce80a8045c70db57084008a3fd98a7f0ba79544e
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-02-05 13:52:08 UTC 
Is there any port requires the cmake files right now? Could we postpone this until the official release?
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-02-06 11:39:50 UTC 
Created attachment 239943 [details]
Patch for popt v3

Fold all backport patches into one file
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-02-06 11:42:28 UTC 
Hi,

We are seeing more and more projects moving away from GNU Autotools and more requests of providing .cmake files (PR 260402, 267652 for example) so instead of holding up development why not be proactive?

Best regards,
Daniel
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-04-08 05:28:58 UTC 
I'll move to cmake with the new release if needed but not now.