Summary: | lang/go119 may use the wrong timer on arm64 | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Andrew Turner <Andrew> |
Component: | Individual Port(s) | Assignee: | Golang Team (Nobody) <go> |
Status: | Closed FIXED | ||
Severity: | Affects Some People | CC: | dan.kotowski, dmgk |
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(go) |
Version: | Latest | ||
Hardware: | arm64 | ||
OS: | Any |
Description
Andrew Turner
2023-01-20 13:27:08 UTC
go1.20 is expected to be released in about 2 weeks and we'll switch the default Go version shortly after that. https://go-review.googlesource.com/c/go/+/422977 probably could be backported to go1.19 too, although I don't know if that's really needed given that go1.20 has this fixed. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=93d574ea957decec1c95dea9bfa8bc72457cc60d commit 93d574ea957decec1c95dea9bfa8bc72457cc60d Author: Andrew Turner <andrew@FreeBSD.org> AuthorDate: 2023-03-10 12:43:59 +0000 Commit: Andrew Turner <andrew@FreeBSD.org> CommitDate: 2023-03-14 10:37:36 +0000 Always enable the virtual timer for userspace We always have it, some languages assume it's present, e.g. go before 1.20. Enable it by default on arm and arm64. PR: 269070 Reviewed by: kevans Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D39059 sys/arm/arm/generic_timer.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=21ef40aea1d312910163a25a890c679814936c11 commit 21ef40aea1d312910163a25a890c679814936c11 Author: Andrew Turner <andrew@FreeBSD.org> AuthorDate: 2023-03-10 12:43:59 +0000 Commit: Andrew Turner <andrew@FreeBSD.org> CommitDate: 2023-05-15 07:59:43 +0000 Always enable the virtual timer for userspace We always have it, some languages assume it's present, e.g. go before 1.20. Enable it by default on arm and arm64. PR: 269070 Reviewed by: kevans Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D39059 (cherry picked from commit 93d574ea957decec1c95dea9bfa8bc72457cc60d) sys/arm/arm/generic_timer.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) ^Triage: close as committed to 14 and MFCed to 13. |