Bug 269121

Summary: www/tor-browser: update to 12.0.2
Product: Ports & Packages Reporter: Rene Ladan <rene>
Component: Individual Port(s)Assignee: Rene Ladan <rene>
Status: Closed FIXED    
Severity: Affects Only Me CC: freebsd, jsm, vvd
Priority: --- Flags: freebsd: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
update www/tor-browser none

Description Rene Ladan freebsd_committer freebsd_triage 2023-01-23 21:09:21 UTC
Created attachment 239667 [details]
update www/tor-browser

Patch to update www/tor-browser to its latest patch release, 12.0.2

Note that I had to bump instead of remove PORTREVISION because the old DISTVERSION "12.0-2" is translated to "12.0.2" too by `make -V PKGNAME` 

I also changed some Makefile logic to be less repetitive with the various version numbers, which should help with future updates.
Comment 1 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2023-01-24 16:01:40 UTC
(In reply to Rene Ladan from comment #0)
Hi Rene,

Please consider adding https://bugs.freebsd.org/bugzilla/attachment.cgi?id=239504&action=diff

It closes bug #268584 and adds firefox build options in order to be able to e.g build without pulseaudio.

Thanks !
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2023-01-24 21:37:37 UTC
(In reply to Jesper Schmitz Mouridsen from comment #1)

Hmm, wouldn't it be easier to have two seperate commits? I could commit the two commits with one push if you like? Or am I misunderstanding something?
Comment 3 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2023-01-24 21:46:33 UTC
(In reply to Rene Ladan from comment #2)
Sounds good to split the changes up in two commits.
Comment 4 Jesper Schmitz Mouridsen freebsd_committer freebsd_triage 2023-02-04 16:35:08 UTC
(In reply to Rene Ladan from comment #0)
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=239667&action=diff#b/www/tor-browser/distinfo_sec1

Did something go wrong with distinfo? It seems to point to an older version if I am not mistaken..
Thanks.
Comment 5 Rene Ladan freebsd_committer freebsd_triage 2023-02-07 19:53:36 UTC
(In reply to Jesper Schmitz Mouridsen from comment #4)

No, the old distinfo points to a Tor browser based on Firefox ESR 102.5 and the new distinfo points to a Tor browser based on Firefox ESR 102.7.

The version numbers of the Tor browser itself are indeed confusing, hence the PORTREVISION bump.
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-02-12 15:35:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b47b8dd54f32b2335de4d3dbe6fc0680ee151de4

commit b47b8dd54f32b2335de4d3dbe6fc0680ee151de4
Author:     Rene Ladan <rene@FreeBSD.org>
AuthorDate: 2023-02-12 15:24:26 +0000
Commit:     Rene Ladan <rene@FreeBSD.org>
CommitDate: 2023-02-12 15:34:10 +0000

    www/tor-browser: update to 12.0.2

    Note the PORTREVISION bump to 3, because the old 12.0-2 and the new
    12.0.2 version both evaluate to 12.0.2 for PKGVERSION

    Generalize Makefile a bit.

    PR:             269121
    Approved by:    maintainer (freebsd@sysctl.cz)

 www/tor-browser/Makefile                      | 13 +++++++------
 www/tor-browser/distinfo                      |  6 +++---
 www/tor-browser/files/patch-bug1773070 (gone) | 26 --------------------------
 3 files changed, 10 insertions(+), 35 deletions(-)
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2023-02-12 17:09:53 UTC
===>   tor-browser-12.0.2_3 depends on file: /usr/local/sbin/pkg - found
=> src-firefox-tor-browser-102.7.0esr-12.0-1-build1.tar.xz doesn't seem to exist in /usr/ports/distfiles//.
===> /!\ Warning /!\
     The :DEFAULT group used for src-firefox-tor-browser-102.7.0esr-12.0-1-build1.tar.xz is missing
     from MASTER_SITES. Check for typos, or errors.
=> Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/src-firefox-tor-browser-102.7.0esr-12.0-1-build1.tar.xz
fetch: http://distcache.FreeBSD.org/ports-distfiles/src-firefox-tor-browser-102.7.0esr-12.0-1-build1.tar.xz: Not Found
=> Couldn't fetch it - please try to retrieve this
=> port manually into /usr/ports/distfiles// and try again.
Comment 8 Rene Ladan freebsd_committer freebsd_triage 2023-02-12 22:58:41 UTC
(In reply to VVD from comment #7)
That was a last-minute suggestion of portlint which I typed in wrong, this was fixed in commit 56774f85f4274f0933c49cc1f5d724484d779110