Bug 269491

Summary: www/node18: www/node19: www/node16: honor ccache for build
Product: Ports & Packages Reporter: Matthias Andree <mandree>
Component: Individual Port(s)Assignee: Po-Chuan Hsieh <sunpoet>
Status: Closed FIXED    
Severity: Affects Only Me CC: mandree, otis, sunpoet
Priority: --- Keywords: patch, patch-ready
Version: LatestFlags: sunpoet: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch: www/node18: www/node19: honor ccache for build
mandree: maintainer-approval? (sunpoet)
Use ccache when available none

Description Matthias Andree freebsd_committer freebsd_triage 2023-02-11 12:06:48 UTC
Created attachment 240084 [details]
patch: www/node18: www/node19: honor ccache for build

This works because CCACHE_BIN is empty if not requested.
Comment 1 Juraj Lutter freebsd_committer freebsd_triage 2023-02-13 07:47:48 UTC
LGTM. With this, www/node16 builds in just over 2 minutes.
Comment 2 Juraj Lutter freebsd_committer freebsd_triage 2023-02-13 19:53:16 UTC
Created attachment 240135 [details]
Use ccache when available

Set tools properly.
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2023-02-20 16:52:30 UTC
LGTM. Thanks.
Comment 4 Matthias Andree freebsd_committer freebsd_triage 2023-02-20 22:06:53 UTC
Thanks for the approval.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-02-20 22:07:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=01927a4913fa76325592b3331f39fcf0d2aa36de

commit 01927a4913fa76325592b3331f39fcf0d2aa36de
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2023-02-11 12:00:48 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2023-02-20 22:06:37 +0000

    www/node18: www/node19: honor ccache for build

    This works because CCACHE_BIN is empty if not requested.

    Approved by:    sunpoet@ (maintainer)
    PR:             269491

 www/node18/Makefile | 4 ++--
 www/node19/Makefile | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-02-20 22:09:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=982f1ce4b4370b5892147e0e4b420f3ac2224c30

commit 982f1ce4b4370b5892147e0e4b420f3ac2224c30
Author:     Juraj Lutter <otis@FreeBSD.org>
AuthorDate: 2023-02-13 10:44:49 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2023-02-20 22:08:51 +0000

    www/node16: Use ccache if available

    Set CC_host and CXX_host to also use ccache when available. This helps
    to speed up the build significantly.

    And while here, also portclippy/portfmt a bit.

    PR:             269491

 www/node16/Makefile | 121 ++++++++++++++++++++++++++++------------------------
 1 file changed, 65 insertions(+), 56 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-02-21 11:11:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c17cd31dfb63a90bb7b11fb826706b56694b7fef

commit c17cd31dfb63a90bb7b11fb826706b56694b7fef
Author:     Juraj Lutter <otis@FreeBSD.org>
AuthorDate: 2023-02-13 10:44:49 +0000
Commit:     Juraj Lutter <otis@FreeBSD.org>
CommitDate: 2023-02-21 11:10:35 +0000

    www/node16: Update to 16.19.1 and use ccache if available

    - Update to 16.19.1
    - Set CC_host and CXX_host to also use ccache when available. This helps
    to speed up the build significantly.

    And while here, also portclippy/portfmt a bit.

    PR:             269491

 www/node16/Makefile | 11 +++++++----
 www/node16/distinfo |  6 +++---
 2 files changed, 10 insertions(+), 7 deletions(-)