Bug 269501
| Summary: | math/py-pyclipper: Update to 1.3.0.post4 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | eduardo, lantw44 | ||||||
| Priority: | --- | Flags: | lantw44:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Comment on attachment 240096 [details] patch >--- a/math/py-pyclipper/Makefile >+++ b/math/py-pyclipper/Makefile >@@ -1,5 +1,5 @@ > PORTNAME= pyclipper >-PORTVERSION= 1.2.1 >+DISTVERSION= 1.3.0.post4 It seems the version number causes pkg to consider it a pre-release. $ pkg version -t 1.3.0 1.3.0.p4 > Created attachment 240773 [details]
Suggested patch
I would add .postX to DISTVERSIONSUFFIX and bump PORTREVISION. This is the minimal/simplest change. See also ports b428002358f848c32ccf16a2c2de222ca956689f. (In reply to Po-Chuan Hsieh from comment #3) Did you mean we should prefer dropping the post-release segment to keeping it as a patch level version? I followed what the handbook said for 'when the version contains letters meaning "patch level"' when finding the solution for the issue. https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-versions-ex4 (In reply to Ting-Wei Lan from comment #4) I have a similar doubt with "release canditate": (https://github.com/kopia/kopia/releases/tag/v0.13.0-rc1) DISTVERSIONPREFIX= v DISTVERSION= 0.13.0-rc1 that is translated to: $ make -VPKGNAME kopia-0.13.0.rc1 $ pkg version -t 0.13.0 0.13.0.rc1 > That is correct for this particular case. (Same result using PORTVERSION) Any correction on this example? Thanks (In reply to Nuno Teixeira from comment #5) (...) ooops: kopia-0.13.0.rc1 PORTVERSION 0.13.0-rc1 may not contain '-' '_' or ','. (In reply to Nuno Teixeira from comment #6) (...) Error was from using PORTVERSION. No error and no problem fetching distfile from github (In reply to Nuno Teixeira from comment #5) Using DISTVERSION works for pre-releases, but it doesn't work for post-releases. The maintainer's patch is committed with a minor version bump and strip addition. Thanks! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0afb957dcd29b11c77f7d53ebc0da67a9f180589 commit 0afb957dcd29b11c77f7d53ebc0da67a9f180589 Author: Yuri Victorovich <yuri@FreeBSD.org> AuthorDate: 2023-12-11 17:52:29 +0000 Commit: Yuri Victorovich <yuri@FreeBSD.org> CommitDate: 2023-12-11 17:54:58 +0000 math/py-pyclipper: update 1.2.1 → 1.3.0p5 PR: 269501 Submitted by: lantw44@gmail.com (maintainer), with minor alteration and addition math/py-pyclipper/Makefile | 14 ++++++++++---- math/py-pyclipper/distinfo | 6 +++--- 2 files changed, 13 insertions(+), 7 deletions(-) |
Created attachment 240096 [details] patch