Bug 269685

Summary: porters-handbook: 3.1 example Makefile ftp does not exist anymore
Product: Documentation Reporter: Paul Dufresne <dufresnep>
Component: Books & ArticlesAssignee: Sergio Carlavilla Delgado <carlavilla>
Status: Closed FIXED    
Severity: Affects Only Me CC: carlavilla, jrm
Priority: ---    
Version: Latest   
Hardware: amd64   
OS: Any   

Description Paul Dufresne 2023-02-19 14:31:48 UTC 
The Makefile example (oneko) in 3.1 have:
MASTER_SITES=	ftp://ftp.cs.columbia.edu/archives/X11R5/contrib/

but:
$ ftp ftp.cs.colombia.edu
ftp: Can't lookup `ftp.cs.colombia.edu:ftp': Name does not resolve
ftp>
Comment 1 Joseph Mingrone freebsd_committer freebsd_triage 2023-02-19 17:30:43 UTC 
As an example, it doesn't seem to matter whether the ftp site is still active or not.

However, if you can offer a compelling reason to swap out the example port for a current port with an active MASTER_SITES, I can make that change.
Comment 2 Paul Dufresne 2023-02-19 23:22:36 UTC 
(In reply to Joseph Mingrone from comment #1)

Well... was feeling I should try rather than just read... and it did not worked.

Feels to me like a very low priority, but worth to be kept in bug database.

I might consider to propose a patch eventually.
Comment 3 Sergio Carlavilla Delgado freebsd_committer freebsd_triage 2023-04-09 17:36:10 UTC 
(In reply to Joseph Mingrone from comment #1)
Are you ok if I change the example to ftp://ftp.rediris.es/sites/ftp.freebsd.org/pub/FreeBSD/?
Comment 4 Joseph Mingrone freebsd_committer freebsd_triage 2023-04-09 17:44:36 UTC 
(In reply to Sergio Carlavilla Delgado from comment #3)
yes
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-04-09 17:53:11 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/doc/commit/?id=f8639b9b29c8728d94ccd9e6f27f3ea10aaeff2e

commit f8639b9b29c8728d94ccd9e6f27f3ea10aaeff2e
Author:     Sergio Carlavilla Delgado <carlavilla@FreeBSD.org>
AuthorDate: 2023-04-09 17:50:52 +0000
Commit:     Sergio Carlavilla Delgado <carlavilla@FreeBSD.org>
CommitDate: 2023-04-09 17:50:52 +0000

    Porters - Quick Porting: Upgrade FTP url to a working one

    PR:             269685
    Reviewed by:    jrm@

 .../content/en/books/porters-handbook/quick-porting/_index.adoc         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 Sergio Carlavilla Delgado freebsd_committer freebsd_triage 2023-04-09 17:53:33 UTC 
Fixed!