Bug 269756

Summary: devel/mongo-c-driver add ICU option
Product: Ports & Packages Reporter: Hiroo Ono <hiroo.ono+freebsd>
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Only Me CC: fernape, ports
Priority: --- Flags: bugzilla: maintainer-feedback? (ports)
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/mongodb/mongo-c-driver/tree/1.23.2
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269506
Bug Depends on:    
Bug Blocks: 269506    
Attachments:
Description Flags
add ICU option for non ASCII user name.
none
add ICU option for non ASCII user name none

Description Hiroo Ono 2023-02-22 12:25:19 UTC 
Created attachment 240327 [details]
add ICU option for non ASCII user name.

devel/mongo-c-driver should set ENABLE_ICU on and off, but I missed it.

Client Side Field Encryption should not be set ON, because it will make circular dependency with libmongocrypt which I'm reporting in bug #269506 .
Comment 1 Krzysztof 2023-02-22 12:36:06 UTC 
Comment on attachment 240327 [details]
add ICU option for non ASCII user name.

I approve.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2023-02-24 13:11:57 UTC 
Thanks for the patch.

Unfortunately, it doesn't apply for me. The context of the patch has this line:

LIB_DEPENDS=   libsasl2.so:security/cyrus-sasl2 \

that it is not in the repo:

https://cgit.freebsd.org/ports/tree/devel/mongo-c-driver/Makefile#n14

Would you mind having a look at it?

Thanks!
Comment 3 Hiroo Ono 2023-02-26 10:41:53 UTC 
Created attachment 240419 [details]
add ICU option for non ASCII user name

Sorry, it seems that I forgot git pull before making patch.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-02-26 19:34:56 UTC 
(In reply to Hiroo Ono from comment #3)
No worries.

Thanks for the update.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2023-02-26 21:29:54 UTC 
Committed,

Thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-02-26 21:30:35 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6df66a2992321bf9ae69b0ac2023215960ebe3a9

commit 6df66a2992321bf9ae69b0ac2023215960ebe3a9
Author:     Hiroo Ono <hiroo.ono+freebsd@gmail.com>
AuthorDate: 2023-02-26 19:33:43 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-02-26 21:24:58 +0000

    devel/mongo-c-driver: add ICU option

    For non ASCII user name.

    PR:             269756
    Reported by:    hiroo.ono+freebsd@gmail.com
    Approved by:    ports@bsdserwis.com (maintainer)

 devel/mongo-c-driver/Makefile | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
Comment 7 Krzysztof 2023-03-01 08:16:14 UTC 
Should this bug be closed?
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2023-03-01 09:21:10 UTC 
(In reply to Krzysztof from comment #7)
Yes of course!

Thanks for the heads up.