Bug 269766

Summary: guitarix-lv2 don't build witn zita-resampler 1.10
Product: Ports & Packages Reporter: sven.a.jonsson
Component: Individual Port(s)Assignee: Yuri Victorovich <yuri>
Status: Closed FIXED    
Severity: Affects Only Me CC: dev, fernape, yuri
Priority: --- Flags: fernape: maintainer-feedback? (yuri)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Fix build with zita-resampler 1.10, switch to github. none

Description sven.a.jonsson 2023-02-22 20:57:45 UTC 
As i just reported at "https://github.com/brummer10/guitarix/issues/122", guitarix checks that zita-resampler is version 1 by checking the value of ZITA_RESAMPLER_MAJOR_VERSION. But the include files from zita-resampler 1.10.1 does not provide that variable.
Fixes I can think of while waiting for an upstream fix could be to either use the zita-resampler that comes with guitarix, or disable the version check.
Comment 1 sven.a.jonsson 2023-02-23 05:16:54 UTC 
I have recieved this answer from upstream:
Hi
Thanks for reporting the issue. I haven't checked out zita-resampler 1.10 for now.
Still, as we provided zita-resampler included in the source there is no reason to fail at this step.
So now, when the zita-resampler test fail we'll switch to use the internal version instead refuse compile.
At some point later I'll implement a check for >1.10

and made this commit, that as far as i can see should fix the issue: "https://github.com/brummer10/guitarix/commit/53560efbbc44a971b7b10290d96b059b67c71eed"
Comment 2 sven.a.jonsson 2023-02-23 05:20:59 UTC 
To clarify my previous comment; the fix was made by upstream, not me :)
Comment 3 Florian Walpen 2023-03-01 16:22:56 UTC 
Created attachment 240511 [details]
Fix build with zita-resampler 1.10, switch to github.

Fix the build by including the upstream patch. Also switch the sources to github, as upstream development seems to happen there now:
https://github.com/brummer10/guitarix/issues/123

Please test and adjust if needed, I only made some test builds and I'm not using these plugins currently.
Comment 4 Florian Walpen 2023-03-01 16:27:30 UTC 
Also maybe we should switch WWW to the official site:
https://guitarix.org/
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2023-03-06 18:59:25 UTC 
Committed, thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-03-06 18:59:40 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=865b99eb888dd88474106280eb179c2c6eb04886

commit 865b99eb888dd88474106280eb179c2c6eb04886
Author:     Florian Walpen <dev@submerge.ch>
AuthorDate: 2023-03-06 16:31:22 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2023-03-06 18:59:17 +0000

    audio/guitarix-lv2: Backport patches fixing build with zita-resampler 1.10; Change to GitHub

    PR:             269766

 audio/guitarix-lv2/Makefile | 11 ++++++++---
 audio/guitarix-lv2/distinfo |  8 +++++---
 2 files changed, 13 insertions(+), 6 deletions(-)