Bug 269822

Summary: editors/uemacs: Fix build with Clang 15
Product: Ports & Packages Reporter: mail
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Some People CC: fuz, grahamperrin
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://www.freshports.org/editors/uemacs/
Attachments:
Description Flags
Use -Wno-int-conversion flag mail: maintainer-approval+

Description mail 2023-02-25 11:29:59 UTC
Created attachment 240406 [details]
Use -Wno-int-conversion flag

As reported by José Pérez on the freebsd-ports list, editors/uemacs fails to build on 14.0-CURRENT 1400079, due to Clang 15 treating implicit pointer/integer conversions as errors.

This patch uses the -Wno-int-conversion compiler flag as suggested by Dimitry Andric, treating the conversion as a warning like previous versions of Clang.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-03-02 16:25:31 UTC
Strongly consider removing -Werror instead of adding more warning flags.
Comment 2 mail 2023-03-03 04:42:13 UTC
(In reply to Robert Clausecker from comment #1)

I don't believe -Werror is set anywhere in the uemacs source, nor the port's Makefile.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-03-03 09:32:15 UTC
(In reply to mail from comment #2)

Ah yes I see, thank you for the explanation.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-03-03 21:31:56 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3c426844b505ca60455f52608fe27dceef5e9d82

commit 3c426844b505ca60455f52608fe27dceef5e9d82
Author:     Andrew Clarke <mail@ozzmosis.com>
AuthorDate: 2023-03-02 16:27:05 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-03-03 21:31:09 +0000

    editors/uemacs: fix build with LLVM 15

    Silence -Wint-conversion to have the build succeed.

    PR:             269822
    Approved by:    eduardo (mentor)
    Differential Revision: https://reviews.freebsd.org/D38871

 editors/uemacs/Makefile | 2 ++
 1 file changed, 2 insertions(+)
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-03-03 21:33:20 UTC
Thank you for your contribution.