Bug 269972

Summary: print/gimp-gutenprint: print.c:117:29: error: incompatible pointer to integer conversion
Product: Ports & Packages Reporter: O. Hartmann <ohartmann>
Component: Individual Port(s)Assignee: Christoph Moench-Tegeder <cmt>
Status: Closed FIXED    
Severity: Affects Many People CC: freebsd, rhurlin
Priority: --- Flags: bugzilla: maintainer-feedback? (cmt)
Version: Latest   
Hardware: Any   
OS: Any   

Description O. Hartmann 2023-03-05 07:56:31 UTC 
Host: FreeBSD 14.0-CURRENT #32 main-n261307-d2ae03bae2ad: Fri Mar  3 18:07:51 CET 2023 amd64, ports tree is most recent git pull of latest tree sources.

Trying to compile graphics/gimp which includes print/gimp-gutenprint results in an compilation error, see below:


[...]
2 warnings generated.
mv -f .deps/print-gutenprint.Tpo .deps/print-gutenprint.Po
/bin/sh ../../libtool  --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I../..  -I../../include -I../../include  -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -Wformat -Werror=format-security -Wmissing-prototypes -I/usr/local/include  -Disfinite=finite -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -O3  -I/usr/local/include/gtk-2.0 -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/harfbuzz -I/usr/local/include/freetype2 -I/usr/local/include/libpng16 -I/usr/local/include/fribidi -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/atk-1.0 -D_THREAD_SAFE -pthread  -Disfinite=finite -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing  -O3 -MT libgutenprintui2_la-printrcl.lo -MD -MP -MF .deps/libgutenprintui2_la-printrcl.Tpo -c -o libgutenprintui2_la-printrcl.lo `test -f 'printrcl.c' || echo './'`printrcl.c

print.c:117:29: error: incompatible pointer to integer conversion passing 'void *' to parameter of type 'gint32' (aka 'int') [-Wint-conversion]
  gint x = gimp_image_width(image_ID);
[...]
Comment 1 Mina Galić freebsd_triage 2023-03-05 10:49:50 UTC 
is upstream informed of this?
Comment 2 O. Hartmann 2023-03-05 13:11:10 UTC 
Has maintainer informed upstream?
Comment 3 Rainer Hurling freebsd_committer freebsd_triage 2023-03-05 16:34:47 UTC 
I think this happens because newer 14.0-CURRENT (>= 1400079) uses LLVM15. The following works for me as a workaround:

CFLAGS+=        -Wno-error=int-conversion    

HTH,
Rainer
Comment 4 Mina Galić freebsd_triage 2023-03-05 16:43:38 UTC 
the workarounds are well known, yes.
but reporting the issue to upstream gives them the opportunity to actually fix it
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-03-05 17:14:02 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=68c402ae8744294ecb65d34960dea1fd233b9411

commit 68c402ae8744294ecb65d34960dea1fd233b9411
Author:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
AuthorDate: 2023-03-05 17:11:54 +0000
Commit:     Christoph Moench-Tegeder <cmt@FreeBSD.org>
CommitDate: 2023-03-05 17:11:54 +0000

    print/gutenprint: fix build with LLVM 15

    as observed on -CURRENT as of now.

    PR:             269972
    Reported by:    ohartmann@walstatt.org

 print/gutenprint/files/patch-src_gimp2_print.c (new) | 13 +++++++++++++
 1 file changed, 13 insertions(+)
Comment 6 Christoph Moench-Tegeder freebsd_committer freebsd_triage 2023-03-05 17:31:01 UTC 
Didn't even remember that I still "maintained" this port.
Upstream is mostly dead, last real release was nearly 4 years ago; 5.3 is still considered "development" and was released last (but not even properly announced) 3 years ago. I don't even have a supported (by this port) printer for years, so now it's up for grabs.
Comment 7 O. Hartmann 2023-03-05 17:53:46 UTC 
(In reply to Christoph Moench-Tegeder from comment #6)

Port graphics/gimp reels in port print/gutenprint via print/gimp-gutenprint.

Question is: is print/gimp-gutenprint really necessary?

Kind regards,
oh