Bug 270038

Summary: multimedia/vlc: fails with ASLR enabled
Product: Ports & Packages Reporter: Ed Maste <emaste>
Component: Individual Port(s)Assignee: freebsd-multimedia (Nobody) <multimedia>
Status: Closed FIXED    
Severity: Affects Only Me CC: jrm, pmc
Priority: --- Flags: bugzilla: maintainer-feedback? (multimedia)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 259968    

Description Ed Maste freebsd_committer freebsd_triage 2023-03-08 13:58:34 UTC 
Ref. thread at
https://lists.freebsd.org/archives/freebsd-stable/2023-March/001178.html

Problem:
Some 1 or 2 minutes into the flight, vlc does continue to play A+V,
but the GUI does not react and does not get refreshed anymore. At
the same time, coredumps are generated (quite a lot of them).

And report that it works with noaslr tag:
https://lists.freebsd.org/archives/freebsd-stable/2023-March/001181.html

diff --git a/multimedia/vlc/Makefile b/multimedia/vlc/Makefile
index 4529d05caea5..c3df51cd2170 100644
--- a/multimedia/vlc/Makefile
+++ b/multimedia/vlc/Makefile
@@ -27,6 +27,8 @@ RUN_DEPENDS=  ffmpeg>=3.4.1,1:multimedia/ffmpeg
 
 USES=          compiler:c++17-lang cpe desktop-file-utils gettext-tools gmake gnome \
                iconv:wchar_t libtool localbase pathfix pkgconfig tar:xz
+USES+=         elfctl
+ELF_FEATURES+= +noaslr:bin/.libs/vlc
 
 CPE_VENDOR=    videolan

Looks good so far. The effect happens randomly in about 80% of
invocations (no idea about when and why), so no guarantee, but I don't
see reason why it shouldn't work.

In the short term we'll want to add the tag to the port.
We'll also need to investigate the cause of the failure and fix the underlying problem (and revert the tagging).
Comment 1 Ed Maste freebsd_committer freebsd_triage 2023-03-08 14:05:08 UTC 
(In reply to Ed Maste from comment #0)
Hrm, markup above is not clear. Other than the links themselves and the final paragraph ("In the short term...") in the description above the text is quoted from Peter's mailing list posts.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-03-10 14:04:12 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=345272090c1216afd333c23a5b06494cb1961333

commit 345272090c1216afd333c23a5b06494cb1961333
Author:     Joseph Mingrone <jrm@FreeBSD.org>
AuthorDate: 2023-03-08 20:24:47 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2023-03-10 14:02:20 +0000

    multimedia/vlc: Turn off ASLR

    Starting with 13.2, elf processes will have ASLR turned on by default.
    However, the vlc binary core dumps with ASLR on, so turn it off until a
    proper fix can be found.

    This fix is based on a discussion between emaste and Peter
    <pmc@citylink.dinoex.sub.org>.

    See also:       https://lists.freebsd.org/archives/freebsd-stable/2023-March/001181.html
    PR:             270038

    Reviewed by:    emaste, mjg, riggs
    Approved by:    multimedia (tcberner, maintainer)
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D38994

 multimedia/vlc/Makefile | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-03-10 14:45:19 UTC 
A commit in branch 2023Q1 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4f66eb5be41f75628d97511da21b78bf0a70b4a3

commit 4f66eb5be41f75628d97511da21b78bf0a70b4a3
Author:     Joseph Mingrone <jrm@FreeBSD.org>
AuthorDate: 2023-03-08 20:24:47 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2023-03-10 14:43:08 +0000

    multimedia/vlc: Turn off ASLR

    Starting with 13.2, elf processes will have ASLR turned on by default.
    However, the vlc binary core dumps with ASLR on, so turn it off until a
    proper fix can be found.

    This fix is based on a discussion between emaste and Peter
    <pmc@citylink.dinoex.sub.org>.

    See also:       https://lists.freebsd.org/archives/freebsd-stable/2023-March/001181.html
    PR:             270038

    Reviewed by:    emaste, mjg, riggs
    Approved by:    multimedia (tcberner, maintainer)
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D38994

    (cherry picked from commit 345272090c1216afd333c23a5b06494cb1961333)

 multimedia/vlc/Makefile | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)