Bug 270165
| Summary: | editors/neovim-gtk: new port | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Alan Somers <asomers> | ||||||
| Component: | Individual Port(s) | Assignee: | Alan Somers <asomers> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | fernape | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Hi Alan,
WARN: Makefile: [187]: possible use of "${MKDIR} -p" found. ${MKDIR} includes "-p" by default.
I think we can remove the -p safely.
Another issue. Have you considered to use Makefile.crates as in audio/gnome-podcasts/Makefile.crates? It keeps the crate list from "polluting" the main port Makefile.
Created attachment 240829 [details] Responds to reviewer's comments. Cumulative with first patch. (In reply to Fernando Apesteguía from comment #1) > I think we can remove the -p safely. Oh darn, I missed that! Fixed in the latest patch. > Another issue. Have you considered to use Makefile.crates as in > audio/gnome-podcasts/Makefile.crates? It keeps the crate list from "polluting" > the main port Makefile. No, I didn't know about that feature. But it looks handy! Fixed in the latest patch. (In reply to Alan Somers from comment #2) Thanks for the changes. Looks good. Build testing... LGTM!
Build tested in 12.4{amd64,i386}, 13.1amd64, current amd64.
Run tested in 13.1amd64.
^Triage: reporter is committer, assign accordingly. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4bc4d0fcbe9aa2a278d67ad7eb4f48b7510a41e5 commit 4bc4d0fcbe9aa2a278d67ad7eb4f48b7510a41e5 Author: Alan Somers <asomers@FreeBSD.org> AuthorDate: 2023-03-13 00:10:37 +0000 Commit: Alan Somers <asomers@FreeBSD.org> CommitDate: 2023-03-14 17:08:05 +0000 editors/neovim-gtk: new port It's a GTK UI for neovim PR: 270165 Approved by: fernape (ports) editors/Makefile | 1 + editors/neovim-gtk/Makefile (new) | 35 ++++ editors/neovim-gtk/Makefile.crates (new) | 159 +++++++++++++++ editors/neovim-gtk/distinfo (new) | 319 +++++++++++++++++++++++++++++++ editors/neovim-gtk/pkg-descr (new) | 4 + editors/neovim-gtk/pkg-plist (new) | 7 + 6 files changed, 525 insertions(+) |
Created attachment 240804 [details] Adds the editors/neovim-gtk port It's a GTK ui for neovim