Bug 270179

Summary: audio/cmus: FFmpeg 6.0 compatibility fix
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Nuno Teixeira <eduardo>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (eduardo)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 261302    
Attachments:
Description Flags
Patch for cmus none

Description Daniel Engberg freebsd_committer freebsd_triage 2023-03-13 15:29:25 UTC 
Created attachment 240821 [details]
Patch for cmus

Required to build with FFmpeg 6.0

Reference:
https://git.alpinelinux.org/aports/tree/community/cmus/ffmpeg6.patch
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2023-03-13 15:41:29 UTC 
Compile tested on FreeBSD 13.2-BETA1
Poudriere testport OK 12.3-RELEASE (amd64)
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2023-03-14 08:19:30 UTC 
Hello Daniel,

Thanks for the patch and nice to ear about ffmpeg update soon.

I've searched cmus issues but didn't found anything there about.
Should a issue be opened? I could do that.

Cheers
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2023-03-14 08:49:35 UTC 
Should I wait for ffmpeg update for commit?
Build tests are fine and test run went ok.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2023-03-14 09:10:51 UTC 
I couldn't find anything mentioned upstream about it so feel free to create an issue about it.
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2023-03-14 11:07:00 UTC 
(In reply to Daniel Engberg from comment #4)

Should this be committed now or should we wait for ffmpeg update commit?
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2023-03-14 11:28:15 UTC 
If it doesn't affect runtime functionality sooner is better otherwise commit it once ffmpeg is in.
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2023-03-14 11:40:51 UTC 
(In reply to Daniel Engberg from comment #6)
Ok, I will do more tests to be sure that ffmpeg supported types run ok.

I've opened an issue: https://github.com/cmus/cmus/issues/1251
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-03-15 08:46:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8cc20c36d14430a87428e2c46238af90b8b50ff8

commit 8cc20c36d14430a87428e2c46238af90b8b50ff8
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-03-15 08:42:15 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-03-15 08:45:11 +0000

    audio/cmus: FFmpeg 6.0 compatibility fix

    Patch required to build with FFmpeg 6.0

    Reference:
    https://git.alpinelinux.org/aports/tree/community/cmus/ffmpeg6.patch

    PR:             270179

 audio/cmus/files/patch-ip_ffmpeg.c (new) | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Comment 9 Nuno Teixeira freebsd_committer freebsd_triage 2023-03-15 08:51:51 UTC 
Committed, thanks!