Bug 270184

Summary: graphics/gstreamer1-plugins-gl: fetches source from git
Product: Ports & Packages Reporter: Dmitry Marakasov <amdmi3>
Component: Individual Port(s)Assignee: freebsd-multimedia (Nobody) <multimedia>
Status: Closed FIXED    
Severity: Affects Many People CC: jhale
Priority: --- Flags: jhale: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   

Description Dmitry Marakasov freebsd_committer freebsd_triage 2023-03-13 18:54:49 UTC 
In presence of `git` utility, gstreamer-plugins-gl fetches some sources via git. Ports are not allowed to access network during the build, so this should be fixed.

`make configure` output diff without and with `git`:

```diff
--- log	2023-03-13 21:49:46.789128000 +0300
+++ log.1	2023-03-13 21:50:20.811180000 +0300
@@ -35,6 +35,9 @@
 ===>   gstreamer1-plugins-gl-1.22.0 depends on shared library: libxml2.so - found (/usr/local/lib/libxml2.so)
 ===>   gstreamer1-plugins-gl-1.22.0 depends on shared library: libgstreamer-1.0.so - found (/usr/local/lib/libgstreamer-1.0.so)
 ===>  Configuring for gstreamer1-plugins-gl-1.22.0
+Cloning into 'gl-headers'...
+Already on 'master'
+Your branch is up to date with 'origin/master'.
 The Meson build system
 Version: 1.0.1
 Source dir: /usr/work/usr/ports/graphics/gstreamer1-plugins-gl/work/gst-plugins-base-1.22.0
@@ -138,9 +141,21 @@
 Program scripts/meson-pkg-config-file-fixup.py found: YES (/usr/work/usr/ports/graphics/gstreamer1-plugins-gl/work/gst-plugins-base-1.22.0/scripts/meson-pkg-config-file-fixup.py)
 Program python3 found: YES (/usr/local/bin/python3.11)
 Looking for a fallback subproject for the dependency (anonymous)
-Git program not found, cannot download gl-headers.wrap via git.
-Subproject  gl-headers is buildable: NO (disabling)
-Dependency (anonymous) from subproject gl-headers found: NO (subproject failed to configure)
+
+Executing subproject gl-headers 
+
+gl-headers| Project name: gl-headers
+gl-headers| Project version: 2019.1.0
+gl-headers| C compiler for the host machine: cc (clang 13.0.0 "FreeBSD clang version 13.0.0 (git@github.com:llvm/llvm-project.git llvmorg-13.0.0-0-gd7b669b3a303)")
+gl-headers| C linker for the host machine: cc ld.lld 13.0.0
+gl-headers| Program python3 found: YES (/usr/local/bin/python3.11)
+gl-headers| Has header "KHR/khrplatform.h" : YES
+gl-headers| Has header "GL/wglext.h" : NO
+gl-headers| Has header "GL/glext.h" : YES
+gl-headers| Build targets in project: 0
+gl-headers| Subproject gl-headers finished.
+
+Dependency (anonymous) from subproject subprojects/gl-headers found: YES 2019.1.0
 Run-time dependency opengl found: YES 4.5
 Run-time dependency glx found: YES 1.4
 Run-time dependency glesv2 found: YES 3.2
@@ -219,8 +234,7 @@
     Plugins           : opengl
 
   Subprojects
-    gl-headers        : NO
-                        Git program not found, cannot download gl-headers.wrap via git.
+    gl-headers        : YES
 
   User defined options
     buildtype         : release

```
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-10-23 08:23:26 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c9d2a05e0208992300ac5be4a84e99d675d801b4

commit c9d2a05e0208992300ac5be4a84e99d675d801b4
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-10-23 07:58:55 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-10-23 08:23:02 +0000

    graphics/gstreamer1-plugins-gl: Prevent fetch during build

    If git(1) was found on the system, the port would attempt to download
    OpenGL headers for a meson subproject from [1], which seems to only be
    necessary/intended for Windows. Add '--wrap-mode=nodownload' to
    MESON_ARGS to prevent this behavior. This only affects builds on live
    systems.

    While here: Remove unused glu dep from USE_GL and add jpeg dep as this
    will link to libjpeg if found on the system. Tiny Makefile order fix.

    [1] https://gitlab.freedesktop.org/gstreamer/meson-ports/gl-headers

    PR:             270184
    Reported by:    amdmi3

 graphics/gstreamer1-plugins-gl/Makefile | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2024-10-23 08:29:42 UTC 
Thanks for the report! This should be fixed now. Sorry this took so long to resolve.