Bug 270195

Summary:

net/realtek-re-kmod - adding support for killer E3000/E3100

Product:

Ports & Packages

Reporter:

Tino Engel <tino.engel>

Component:

Individual Port(s)

Assignee:

Alex Dupre <ale>

Status:

Closed FIXED

Severity:

Affects Some People

CC:

tino.engel

Priority:

---

Flags:

bugzilla: maintainer-feedback? (ale)

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
git formatted patch	none

Description Tino Engel 2023-03-14 09:46:35 UTC

Adding support for Killer E3000/E3100.

https://github.com/freebsd/freebsd-ports/pull/168

====================

Poudriere build log:

build started at Sun Mar 12 14:16:51 CET 2023
port directory: /usr/ports/net/realtek-re-kmod
package name: realtek-re-kmod-198.00
building for: FreeBSD 131Ramd64-default 13.1-RELEASE-p7 FreeBSD 13.1-RELEASE-p7 amd64
maintained by: ale@FreeBSD.org
Makefile ident: 
Poudriere version: 3.3.7_1
Host OSVERSION: 1301000
Jail OSVERSION: 1301000
Job Id: 

---Begin Environment---
SHELL=/bin/csh
OSVERSION=1301000
UNAME_v=FreeBSD 13.1-RELEASE-p7
UNAME_r=13.1-RELEASE-p7
BLOCKSIZE=K
MAIL=/var/mail/root
MM_CHARSET=UTF-8
LANG=C.UTF-8
STATUS=1
HOME=/root
PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
LOCALBASE=/usr/local
USER=root
TRYBROKEN=yes
LIBEXECPREFIX=/usr/local/libexec/poudriere
POUDRIERE_VERSION=3.3.7_1
MASTERMNT=/poudriere/data/.m/131Ramd64-default/ref
POUDRIERE_BUILD_TYPE=bulk
PACKAGE_BUILDING=yes
SAVED_TERM=xterm-256color
GID=0
UID=0
PWD=/poudriere/data/.m/131Ramd64-default/ref/.p
NO_WARNING_PKG_INSTALL_EOL=yes
P_PORTS_FEATURES=FLAVORS SELECTED_OPTIONS
MASTERNAME=131Ramd64-default
SCRIPTPREFIX=/usr/local/share/poudriere
OLDPWD=/poudriere/data/.m/131Ramd64-default/ref/.p/pool
SCRIPTPATH=/usr/local/share/poudriere/testport.sh
POUDRIEREPATH=/usr/local/bin/poudriere
---End Environment---

---Begin Poudriere Port Flags/Env---
PORT_FLAGS=
PKGENV=PACKAGES=/tmp/pkgs PKGREPOSITORY=/tmp/pkgs PKGLATESTREPOSITORY=/tmp/pkgs/Latest
FLAVOR=
DEPENDS_ARGS=
MAKE_ARGS=
---End Poudriere Port Flags/Env---

---Begin OPTIONS List---
---End OPTIONS List---

--MAINTAINER--
ale@FreeBSD.org
--End MAINTAINER--

--CONFIGURE_ARGS--

--End CONFIGURE_ARGS--

--CONFIGURE_ENV--
XDG_DATA_HOME=/wrkdirs/usr/ports/net/realtek-re-kmod/work  XDG_CONFIG_HOME=/wrkdirs/usr/ports/net/realtek-re-kmod/work  XDG_CACHE_HOME=/wrkdirs/usr/ports/net/realtek-re-kmod/work/.cache  HOME=/wrkdirs/usr/ports/net/realtek-re-kmod/work TMPDIR="/tmp" PATH=/wrkdirs/usr/ports/net/realtek-re-kmod/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin PKG_CONFIG_LIBDIR=/wrkdirs/usr/ports/net/realtek-re-kmod/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig SHELL=/bin/sh CONFIG_SHELL=/bin/sh
--End CONFIGURE_ENV--

--MAKE_ENV--
KMODDIR="/boot/modules" SYSDIR="/usr/src/sys" NO_XREF=yes XDG_DATA_HOME=/wrkdirs/usr/ports/net/realtek-re-kmod/work  XDG_CONFIG_HOME=/wrkdirs/usr/ports/net/realtek-re-kmod/work  XDG_CACHE_HOME=/wrkdirs/usr/ports/net/realtek-re-kmod/work/.cache  HOME=/wrkdirs/usr/ports/net/realtek-re-kmod/work TMPDIR="/tmp" PATH=/wrkdirs/usr/ports/net/realtek-re-kmod/work/.bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin PKG_CONFIG_LIBDIR=/wrkdirs/usr/ports/net/realtek-re-kmod/work/.pkgconfig:/usr/local/libdata/pkgconfig:/usr/local/share/pkgconfig:/usr/libdata/pkgconfig MK_DEBUG_FILES=no MK_KERNEL_SYMBOLS=no SHELL=/bin/sh NO_LINT=YES PREFIX=/usr/local  LOCALBASE=/usr/local  CC="cc" CFLAGS="-O2 -pipe  -fno-strict-aliasing "  CPP="cpp" CPPFLAGS=""  LDFLAGS=" " LIBS=""  CXX="c++" CXXFLAGS="-O2 -pipe -fno-strict-aliasing  "  MANPREFIX="/usr/local" BSD_INSTALL_PROGRAM="install  -s -m 555"  BSD_INSTALL_LIB="install  -s -m 0644"  BSD_INSTALL_SCRIPT="install  -m 555"  BSD_INSTALL_DATA="install  -m 0644"  BSD_INSTALL_MAN="install  -m 444"
--End MAKE_ENV--

--PLIST_SUB--
KMODDIR="boot/modules" OSREL=13.1 PREFIX=%D LOCALBASE=/usr/local  RESETPREFIX=/usr/local LIB32DIR=lib DOCSDIR="share/doc/re"  EXAMPLESDIR="share/examples/re"  DATADIR="share/re"  WWWDIR="www/re"  ETCDIR="etc/re"
--End PLIST_SUB--

--SUB_LIST--
PREFIX=/usr/local LOCALBASE=/usr/local  DATADIR=/usr/local/share/re DOCSDIR=/usr/local/share/doc/re EXAMPLESDIR=/usr/local/share/examples/re  WWWDIR=/usr/local/www/re ETCDIR=/usr/local/etc/re
--End SUB_LIST--

---Begin make.conf---
USE_PACKAGE_DEPENDS=yes
BATCH=yes
WRKDIRPREFIX=/wrkdirs
PORTSDIR=/usr/ports
PACKAGES=/packages
DISTDIR=/distfiles
FORCE_PACKAGE=yes
PACKAGE_BUILDING=yes
PACKAGE_BUILDING_FLAVORS=yes
#### Misc Poudriere ####
.include "/etc/make.conf.ports_env"
---End make.conf---
--Resource limits--
cpu time               (seconds, -t)  unlimited
file size           (512-blocks, -f)  unlimited
data seg size           (kbytes, -d)  33554432
stack size              (kbytes, -s)  524288
core file size      (512-blocks, -c)  unlimited
max memory size         (kbytes, -m)  unlimited
locked memory           (kbytes, -l)  unlimited
max user processes              (-u)  63680
open files                      (-n)  1024
virtual mem size        (kbytes, -v)  unlimited
swap limit              (kbytes, -w)  unlimited
socket buffer size       (bytes, -b)  unlimited
pseudo-terminals                (-p)  unlimited
kqueues                         (-k)  unlimited
umtx shared locks               (-o)  unlimited
--End resource limits--
=======================<phase: check-sanity   >============================
===>  License BSD4CLAUSE accepted by the user
===========================================================================
=======================<phase: pkg-depends    >============================
===>   realtek-re-kmod-198.00 depends on file: /usr/local/sbin/pkg - not found
===>   Installing existing package /packages/All/pkg-1.19.1_1.pkg
[131Ramd64-default] Installing pkg-1.19.1_1...
[131Ramd64-default] Extracting pkg-1.19.1_1: .......... done
===>   realtek-re-kmod-198.00 depends on file: /usr/local/sbin/pkg - found
===>   Returning to build of realtek-re-kmod-198.00
===========================================================================
=======================<phase: fetch-depends  >============================
===========================================================================
=======================<phase: fetch          >============================
===>  License BSD4CLAUSE accepted by the user
===>   realtek-re-kmod-198.00 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by realtek-re-kmod-198.00 for building
===========================================================================
=======================<phase: checksum       >============================
===>  License BSD4CLAUSE accepted by the user
===>   realtek-re-kmod-198.00 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by realtek-re-kmod-198.00 for building
=> SHA256 Checksum OK for alexdupre-rtl_bsd_drv-v198.00-7cfa6bf_GH0.tar.gz.
===========================================================================
=======================<phase: extract-depends>============================
===========================================================================
=======================<phase: extract        >============================
===>  License BSD4CLAUSE accepted by the user
===>   realtek-re-kmod-198.00 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by realtek-re-kmod-198.00 for building
===>  Extracting for realtek-re-kmod-198.00
=> SHA256 Checksum OK for alexdupre-rtl_bsd_drv-v198.00-7cfa6bf_GH0.tar.gz.
===========================================================================
=======================<phase: patch-depends  >============================
===========================================================================
=======================<phase: patch          >============================
===>  Patching for realtek-re-kmod-198.00
===>  Applying FreeBSD patches for realtek-re-kmod-198.00 from /usr/ports/net/realtek-re-kmod/files
===========================================================================
=======================<phase: build-depends  >============================
===========================================================================
=======================<phase: lib-depends    >============================
===========================================================================
=>> Recording filesystem state for prebuild... done
=======================<phase: configure      >============================
===>  Configuring for realtek-re-kmod-198.00
===========================================================================
=======================<phase: build          >============================
===>  Building for realtek-re-kmod-198.00
--- machine ---
--- x86 ---
--- objwarn ---
Warning: Object directory not changed from original /wrkdirs/usr/ports/net/realtek-re-kmod/work/rtl_bsd_drv-7cfa6bf
--- machine ---
machine -> /usr/src/sys/amd64/include
--- x86 ---
x86 -> /usr/src/sys/x86/include
--- opt_bdg.h ---
--- opt_global.h ---
--- device_if.h ---
--- bus_if.h ---
--- pci_if.h ---
--- opt_bdg.h ---
:> opt_bdg.h
--- opt_global.h ---
touch opt_global.h
--- device_if.h ---
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/device_if.m -h
--- bus_if.h ---
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/bus_if.m -h
--- pci_if.h ---
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/dev/pci/pci_if.m -h
--- if_re.o ---
cc  -O2 -pipe -fno-strict-aliasing  -Werror -D_KERNEL -DKLD_MODULE -nostdinc   -include /wrkdirs/usr/ports/net/realtek-re-kmod/work/rtl_bsd_drv-7cfa6bf/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include     -MD  -MF.depend.if_re.o -MTif_re.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error=tautological-compare -Wno-error=empty-body -Wno-error=parentheses-equality -Wno-error=unused-function -Wno-error=pointer-sign -Wno-error=shift-negative-value -Wno-address-of-packed-member -Wno-error=unused-but-set-variable -Wno-format-zero-length   -mno-aes -mno-avx  -std=iso9899:1999 -c if_re.c -o if_re.o
--- if_re.ko ---
ld -m elf_x86_64_fbsd -d -warn-common --build-id=sha1 -T /usr/src/sys/conf/ldscript.kmod.amd64 -r -d  -o if_re.ko if_re.o
:> export_syms
awk -f /usr/src/sys/conf/kmod_syms.awk if_re.ko  export_syms | xargs -J% objcopy % if_re.ko
objcopy --strip-debug if_re.ko
===========================================================================
=>> Checking for filesystem violations... done
=======================<phase: run-depends    >============================
===========================================================================
=>> Recording filesystem state for prestage... done
=======================<phase: stage          >============================
===>  Staging for realtek-re-kmod-198.00
===>   Generating temporary packing list
install -T release -o 65534 -g 65534 -m 555   if_re.ko /wrkdirs/usr/ports/net/realtek-re-kmod/work/stage/boot/modules/
====> Compressing man pages (compress-man)
===========================================================================
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
=>> Checking for staging violations... done
=======================<phase: package        >============================
===>  Building package for realtek-re-kmod-198.00
===========================================================================
=>> Recording filesystem state for preinst... done
=======================<phase: install        >============================
===>  Installing for realtek-re-kmod-198.00
===>  Checking if realtek-re-kmod is already installed
===>   Registering installation for realtek-re-kmod-198.00
[131Ramd64-default] Installing realtek-re-kmod-198.00...
Add the following lines to your /boot/loader.conf
to override the built-in FreeBSD re(4) driver.

if_re_load="YES"
if_re_name="/boot/modules/if_re.ko"

By default, the size of allocated mbufs is enough
to receive the largest Ethernet frame supported
by the card.  If your memory is highly fragmented,
trying to allocate contiguous pages (more than
4096 bytes) may result in driver hangs.
For this reason the value is tunable at boot time,
e.g. if you don't need Jumbo frames you can lower
the memory requirements and avoid this issue with:

hw.re.max_rx_mbuf_sz="2048"

===========================================================================
=>> Checking shared library dependencies
=======================<phase: deinstall      >============================
===>  Deinstalling for realtek-re-kmod
===>   Deinstalling realtek-re-kmod-198.00
Updating database digests format: .. done
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
	realtek-re-kmod: 198.00

Number of packages to be removed: 1
[131Ramd64-default] [1/1] Deinstalling realtek-re-kmod-198.00...
[131Ramd64-default] [1/1] Deleting files for realtek-re-kmod-198.00: .... done
===========================================================================
=>> Checking for extra files and directories
[00:01:27] Installing from package
[131Ramd64-default] Installing realtek-re-kmod-198.00...
[131Ramd64-default] Extracting realtek-re-kmod-198.00: .... done
=====
Message from realtek-re-kmod-198.00:

--
Add the following lines to your /boot/loader.conf
to override the built-in FreeBSD re(4) driver.

if_re_load="YES"
if_re_name="/boot/modules/if_re.ko"

By default, the size of allocated mbufs is enough
to receive the largest Ethernet frame supported
by the card.  If your memory is highly fragmented,
trying to allocate contiguous pages (more than
4096 bytes) may result in driver hangs.
For this reason the value is tunable at boot time,
e.g. if you don't need Jumbo frames you can lower
the memory requirements and avoid this issue with:

hw.re.max_rx_mbuf_sz="2048"
[00:01:27] Cleaning up
===>  Cleaning for realtek-re-kmod-198.00
[00:01:27] Deinstalling package
Updating database digests format: . done
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 1 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
	realtek-re-kmod: 198.00

Number of packages to be removed: 1
[131Ramd64-default] [1/1] Deinstalling realtek-re-kmod-198.00...
[131Ramd64-default] [1/1] Deleting files for realtek-re-kmod-198.00: .... done
build of net/realtek-re-kmod | realtek-re-kmod-198.00 ended at Sun Mar 12 14:16:57 CET 2023
build time: 00:00:06

Comment 1 Tino Engel 2023-03-14 11:05:59 UTC

Created attachment 240839 [details]
git formatted patch

Comment 2 commit-hook freebsd_committer

2023-03-15 16:12:47 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=eb22a3e0752dfdd191263ebaa7df3229a0170dcf

commit eb22a3e0752dfdd191263ebaa7df3229a0170dcf
Author:     Alex Dupre <ale@FreeBSD.org>
AuthorDate: 2023-03-15 16:10:02 +0000
Commit:     Alex Dupre <ale@FreeBSD.org>
CommitDate: 2023-03-15 16:11:48 +0000

    net/realtek-re-kmod: add support Killer E3000/E3100 cards (RTL8125)

    PR:             270195
    Submitted by:   Tino Engel <tino.engel@mail.de>

 net/realtek-re-kmod/Makefile | 3 ++-
 net/realtek-re-kmod/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)