Bug 270257
| Summary: | emulators/mgba: Minor build fixes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||
| Component: | Individual Port(s) | Assignee: | Piotr Kubaj <pkubaj> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(pkubaj) |
||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 261302 | ||||||
| Attachments: |
|
||||||
compiler:c++11-lang and compiler:c++14-lang behave the same way, so it's actually better to have them in the main USES. Upstream defines during build c++11 without QT and c++14 with which is why I moved it Yes, but in FreeBSD case, it doesn't matter. All the supported FreeBSD releases have LLVM in base that supports both c++11 and c++14. As for the supported platforms that still use GCC, they all have GCC 4.2, which supports neither c++11 nor c++14 and is set up to use the default GCC in ports. This is why it doesn't make sense to differentiate between various USES=compiler settings (apart from compiler:gcc-c++11-lib, which is vastly different - it explicitly uses GCC and adds linking to libc++). I get what you're saying, I'm just trying to be as correct as possible to the source. You're the maintainer so it's up to you in the end anyway. Best regards, Daniel ...to get this rolling, move compiler:c++14-lang to USES and we're good to go? Yes, that should be ok. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f6c56fe165b212d6112b1305bbc8a9821b1a18f8 commit f6c56fe165b212d6112b1305bbc8a9821b1a18f8 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2023-03-25 14:52:35 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2023-03-25 14:52:39 +0000 emulators/mgba: Minor build fixes Relax definitions of FFMPEG_LIB_DEPENDS, fixes build with FFmpeg 6.0 Update compiler requirements PR: 270257 Reviewed by: pkubaj (maintainer) emulators/mgba/Makefile | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) |
Created attachment 240883 [details] Patch for mgba Relax definitions of FFMPEG_LIB_DEPENDS, fixes build with FFmpeg 6.0 Set compiler requirements correctly Compile tested on FreeBSD 13.2-BETA1 (amd64) Poudriere testport OK 12.3-RELEASE (amd64)