Bug 270280

Summary: ports-mgmt/pkg_replace: update to 20230317
Product: Ports & Packages Reporter: Ken DEGUCHI <kdeguchi>
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Only Me CC: fernape, junchoon
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/kdeguchi/pkg_replace/releases/tag/20230317
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270274
Attachments:
Description Flags
Update to pkg_replace-20230317 kdeguchi: maintainer-approval+

Description Ken DEGUCHI 2023-03-17 00:22:51 UTC 
Created attachment 240914 [details]
Update to pkg_replace-20230317

Fix bug for fetch files (`make -DBATCH checksum` error).

Please see bug #270274.
Comment 1 Tomoaki AOKI 2023-03-17 08:47:02 UTC 
(In reply to Ken DEGUCHI from comment #0)

Thanks! It worked fine.

By the way, if there were some reason for previous code (situations that require "-DBATCH" actually existed), make this conditional like codes after "else" would make sense. (Add "-DBATCH" only if "--batch" option is set.)

If there was no reason, current fixed code is fine.
Comment 2 Ken DEGUCHI 2023-03-18 09:13:44 UTC 
(In reply to Tomoaki AOKI from comment #1)

According to "Mk/bsd.licenses.mk", "IGNORE" is set when "BATCH" is specified. Therefore, I think there is no problem if "-DBATCH" is removed.
Comment 3 Tomoaki AOKI 2023-03-18 17:42:18 UTC 
(In reply to Ken DEGUCHI from comment #2)

Thanks for checking it.

I've looked into logs on current upstream and found that the offending "-DBATCH" already existed at the first import.
The former (original) upstream doesn't seem to have any revision control system and could not determine why it was introduced.

So it would be reasonable to going forward for now, and reconsider if any promlem happenes in the future.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2023-03-19 17:21:30 UTC 
Committed,

Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-03-19 17:22:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ba35ba3b369ecbaa4b2537d9dedf75dfba7d3809

commit ba35ba3b369ecbaa4b2537d9dedf75dfba7d3809
Author:     Ken DEGUCHI <kdeguchi@sz.tokoha-u.ac.jp>
AuthorDate: 2023-03-17 08:24:38 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-03-19 17:16:41 +0000

    ports-mgmt/pkg_replace: update to 20230317

    ChangeLog: https://github.com/kdeguchi/pkg_replace/releases/tag/20230317

    Fix bug for fetch files (`make -DBATCH checksum` error).

    PR:             270280 270274
    Reported by:    kdeguchi@sz.tokoha-u.ac.jp (maintainer)

 ports-mgmt/pkg_replace/Makefile | 2 +-
 ports-mgmt/pkg_replace/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)