Bug 270308

Summary: multimedia/vlc: Mark VAAPI as BROKEN
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: freebsd-multimedia (Nobody) <multimedia>
Status: Closed FIXED    
Severity: Affects Only Me CC: marietto2008, snakedoctr
Priority: --- Flags: bugzilla: maintainer-feedback? (multimedia)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for vlc
none
Patch for vlc #2 none

Description Daniel Engberg freebsd_committer freebsd_triage 2023-03-18 11:49:19 UTC 
Created attachment 240945 [details]
Patch for vlc

Upstream don't support VAAPI on FFmpeg 5.0 or higher

Reference:
https://code.videolan.org/videolan/vlc/-/merge_requests/1245

Compile tested on FreeBSD 13.2-BETA1 (amd64)
Poudriere testport OK 12.3-RELEASE (amd64)
Comment 1 Jan Beich freebsd_committer freebsd_triage 2023-03-18 14:25:58 UTC 
Comment on attachment 240945 [details]
Patch for vlc

All of this can be replaced with

  OPTIONS_EXCLUDE+=VAAPI # incompatible with ffmpeg >= 5 until vlc4

or

  OPTIONS_EXCLUDE+=VAAPI # https://code.videolan.org/videolan/vlc/-/commit/08cbeca2b732

I had a similar issue with libplacebo >= 5.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-03-18 18:21:07 UTC 
Created attachment 240952 [details]
Patch for vlc #2

Use OPT_EXCLUDE helper instead
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-04-27 12:05:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a49368707931fc569e5f084549df5d0ef6bd2bbf

commit a49368707931fc569e5f084549df5d0ef6bd2bbf
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-04-27 10:59:26 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-04-27 12:01:45 +0000

    multimedia/vlc: Disable VA-API

    No support VA-API on FFmpeg 5.0 or higher

    Reference:
    https://code.videolan.org/videolan/vlc/-/merge_requests/1245

    PR:             270308

 multimedia/vlc/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 4 Snake Doc 2024-01-14 16:38:11 UTC 
Is it still the case that ffmpeg 6.1 doesn't support VAAPI?  From packages, ffmpeg-6.1.1,1 has "--enable-vaapi" in the compile options.  I'm hoping VAAPI can be re-enabled in the VLC package to re-enable hardware decoding with VAAPI.
Comment 5 mario felicioni 2024-01-14 17:13:11 UTC 
There is some bug somewhere. I say this because I'm running FreeBSD 14.0 on the UFS partition and I'm using VLC + VAAPI or VDPAU enabled and everything works. But when I do it on FreeBSD 14.0 installed on the ZFS partition,VDPAU does not work.
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2024-01-14 18:00:43 UTC 
From what I can tell most hardware acceleration in VLC is supposed to land in 4.0
Comment 7 mario felicioni 2024-01-14 19:34:16 UTC 
I'm sure that the right combination of packages installed let us work VLC with VDPAU and VAAPI. But its hard to tell which ones.
Comment 8 mario felicioni 2024-01-14 19:34:42 UTC 
anyway,someone knows when VLC 4.0 will land on FreeBSD ?
Comment 9 Daniel Engberg freebsd_committer freebsd_triage 2024-01-14 20:18:18 UTC 
Looking at https://code.videolan.org/videolan/vlc/-/milestones/103 I'd say "a while".

Meanwhile, to my knowledge multimedia/mpv works with hardware acceleration.