Bug 270464

Summary:	security/openvas: error: a function declaration without a prototype is deprecated in all versions of C
Product:	Ports & Packages	Reporter:	O. Hartmann <ohartmann>
Component:	Individual Port(s)	Assignee:	Jose Alonso Cardenas Marquez <acm>
Status:	Closed FIXED
Severity:	Affects Many People	CC:	freebsd, grahamperrin
Priority:	---	Flags:	bugzilla: maintainer-feedback? (acm)
Version:	Latest
Hardware:	Any
OS:	Any
See Also:	https://github.com/greenbone/openvas-scanner/issues/1403

Description O. Hartmann 2023-03-26 14:54:59 UTC

Host: CURRENT
JAIL: CURRENT

Compilation of security/openvas (and all subsequent dependend ports) fails due to the compiler error shown below.

[...]
=>> Building security/openvas
build started at Sun Mar 26 14:46:59 UTC 2023
port directory: /usr/ports/security/openvas
package name: openvas-22.4.0_3
building for: FreeBSD poudriere 14.0-CURRENT FreeBSD 14.0-CURRENT 1400083 amd64
maintained by: acm@FreeBSD.org
Makefile datestamp: -rw-r--r--  1 root  wheel  1497 Nov 19 11:34 /usr/ports/security/openvas/Makefile
Ports top last git commit: 8d02989b9630
Ports top unclean checkout: no
Port dir last git commit: 90068af778de
Port dir unclean checkout: no
Poudriere version: poudriere-git-3.3.99.20220831
Host OSVERSION: 1400082
Jail OSVERSION: 1400083
Job Id: 01




!!! Jail is newer than host. (Jail: 1400083, Host: 1400082) !!!
!!! This is not supported. !!!
!!! Host kernel must be same or newer than jail. !!!
!!! Expect build failures. !!!



---Begin Environment---
SHELL=/bin/sh
OSVERSION=1400083
UNAME_v=FreeBSD 14.0-CURRENT 1400083
UNAME_r=14.0-CURRENT
BLOCKSIZE=K
MAIL=/var/mail/root
MM_CHARSET=UTF-8
LANG=C.UTF-8
STATUS=1
HOME=/root
PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
LOCALBASE=/usr/local
USER=root
POUDRIERE_NAME=poudriere-git
LIBEXECPREFIX=/usr/local/libexec/poudriere
POUDRIERE_VERSION=3.3.99.20220831
MAKEOBJDIRPREFIX=/pool/sources/CURRENT/obj/
MASTERMNT=/pool/poudriere/data/.m/head-amd64-head-default/ref
LC_COLLATE=C
POUDRIERE_BUILD_TYPE=bulk
PACKAGE_BUILDING=yes
SAVED_TERM=screen
OUTPUT_REDIRECTED_STDERR=4
OUTPUT_REDIRECTED=1
PWD=/pool/poudriere/data/.m/head-amd64-head-default/01/.p
OUTPUT_REDIRECTED_STDOUT=3
P_PORTS_FEATURES=FLAVORS SELECTED_OPTIONS
MASTERNAME=head-amd64-head-default
SCRIPTPREFIX=/usr/local/share/poudriere
SCRIPTNAME=bulk.sh
OLDPWD=/pool/poudriere/data/.m/head-amd64-head-default/ref/.p/pool
POUDRIERE_PKGNAME=poudriere-git-3.3.99.20220831
SCRIPTPATH=/usr/local/share/poudriere/bulk.sh
POUDRIEREPATH=/usr/local/bin/poudriere
---End Environment---

---Begin Poudriere Port Flags/Env---
PORT_FLAGS=
PKGENV=
FLAVOR=
DEPENDS_ARGS=
MAKE_ARGS=
---End Poudriere Port Flags/Env---

[...]
misc/CMakeFiles/openvas_misc_shared.dir/plugutils.c.o -MF misc/CMakeFiles/openvas_misc_shared.dir/plugutils.c.o.d -o misc/CMakeFiles/openvas_misc_shared.dir/plugutils.c.o -c /wrkdirs/usr/ports/security/openvas/work/openvas-scanner-22.4.0/misc/plugutils.c
/wrkdirs/usr/ports/security/openvas/work/openvas-scanner-22.4.0/misc/plugutils.c:841:22: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
plug_get_key_sigchld ()
                     ^
                      void
1 error generated.

Comment 1 Mina Galić freebsd_triage

2023-03-26 14:56:42 UTC

have you submitted that to upstream yet?

Comment 2 Mina Galić freebsd_triage

2023-04-29 07:42:44 UTC

this was fixed upstream in February 2022: https://github.com/greenbone/openvas-scanner/pull/1025
i think this is a maintainer timeout

Comment 3 Mina Galić freebsd_triage

2023-04-29 08:33:36 UTC

correction, -Wmissing-prototypes is not the same as -Wstrict-prototypes.
i created an upstream bug: https://github.com/greenbone/openvas-scanner/issues/1403

Comment 4 Jose Alonso Cardenas Marquez freebsd_committer

2023-04-29 22:12:04 UTC

*** Bug 271129 has been marked as a duplicate of this bug. ***

Comment 5 Jose Alonso Cardenas Marquez freebsd_committer

2023-04-29 22:17:31 UTC

(In reply to Mina Galić from comment #2)
Hello, technically it is not a maintainer timeout because no one sent a patch file for commit it. It is more like a alert about problems compiling openvas with clang-15+

Comment 6 Mina Galić freebsd_triage

2023-04-30 06:00:49 UTC

(In reply to Jose Alonso Cardenas Marquez from comment #5)
yeah, sorry. this unfair assessment was based on the idea that this bug is already fixed upstream, which i realised it isn't

Comment 7 Mina Galić freebsd_triage

2023-05-02 13:02:12 UTC

fixed today in upstream: https://github.com/greenbone/openvas-scanner/pull/1405

Comment 8 O. Hartmann 2023-05-17 15:54:03 UTC

I still run into the same error with official ports tree sources and recent builder hosts:

Poudriere version: poudriere-git-3.3.99.20220831
Host OSVERSION: 1400088
Jail OSVERSION: 1302505
Job Id: 02

Comment 9 Jose Alonso Cardenas Marquez freebsd_committer

2023-05-18 20:46:16 UTC

I have updated gvm ports to latest versions. Take a look at 

https://cgit.freebsd.org/ports/commit/?id=4b312f7f6d1cbe0489a104130f35d0412d138212

It could include some patch files for avoid clang issues

Comment 10 O. Hartmann 2023-05-19 07:56:47 UTC

(In reply to Jose Alonso Cardenas Marquez from comment #9)

Thank you very much. Just saw the commit, the poudriere run has just started. But I can report back earliest mid of next week since my builder host  quite antique (IvyBridge propelled ) ...

Comment 11 Jose Alonso Cardenas Marquez freebsd_committer

2023-09-19 18:14:30 UTC

Hi, latest version of openvas is compiling without problems on FreeBSD 14.x. I'll close this PR. Thanks for your report

root@ifrit:~ # uname -a
FreeBSD ifrit 14.0-BETA2 FreeBSD 14.0-BETA2 #0 releng/14.0-n265096-dfd44f2f0143: Fri Sep 15 05:46:35 UTC 2023     root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64
root@ifrit:~ # pkg search openvas
openvas-22.7.0                 Open vulnerability assessment scanner
py39-ospd-openvas-22.5.1       Scanner wrapper for OSP (Open Scanner Protocol)
rubygem-openvas-omp-0.0.4      Communicate with OpenVAS manager through OMP