Bug 270560

Summary: irc/irssi: Update to 1.4.4
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Daniel Engberg <diizzy>
Status: Closed FIXED    
Severity: Affects Only Me CC: dor.bsd, fernape
Priority: --- Flags: dor.bsd: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://irssi.org/NEWS/#news-v1-4-4
Attachments:
Description Flags
Patch for irssi none

Description Daniel Engberg freebsd_committer freebsd_triage 2023-03-31 05:30:53 UTC 
Created attachment 241222 [details]
Patch for irssi

Update to 1.4.4
Drop truecolor option as its now a hard requirement

Reference:
https://github.com/irssi/irssi/commit/b34f16e9df5cbcdd488175a7e4a1ab8e605d3a53

Compile and (lightly) tested on FreeBSD 13.2-RC5 (amd64) (make, make check-plist, make test)
Poudriere testport OK 12.3-RELEASE (amd64)
Poudriere testport OK 13.1-RELEASE (i386)
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2023-03-31 06:57:37 UTC 
^Triage: reporter is committer, assign accordingly
Comment 2 David O'Rourke 2023-03-31 09:23:51 UTC 
Hi,

The MASTER_SITES appears to have an unnecessary line continuation after the codeberg URL, though.

Other than this, it looks good, thanks!
Comment 3 David O'Rourke 2023-03-31 09:34:47 UTC 
Comment on attachment 241222 [details]
Patch for irssi

Looks good, other than the already mentioned extra \ on the codeberg line (which is probably harmless).
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-03-31 18:59:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f5da9192a4bf8429578763bfd1274f94f6f0e70a

commit f5da9192a4bf8429578763bfd1274f94f6f0e70a
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-03-31 18:55:36 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-03-31 18:58:59 +0000

    irc/irssi: Update to 1.4.4

    Changelog: https://irssi.org/NEWS/#news-v1-4-4

    PR:             270560
    Reported by:    Ailin Nemui (upstream)
    Reviewed by:    David O'Rourke <dor.bsd@xm0.uk>

 irc/irssi/Makefile | 10 +++++-----
 irc/irssi/distinfo |  6 +++---
 2 files changed, 8 insertions(+), 8 deletions(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2023-03-31 19:00:44 UTC 
Fixed typo, thanks for quick review :-)