Bug 270589

Summary: www/onlyoffice-documentserver missing dependency pwgen for documentserver-update-securelink.sh
Product: Ports & Packages Reporter: freebsd.org
Component: Individual Port(s)Assignee: Mikael Urankar <mikael>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (mikael)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description freebsd.org 2023-04-01 22:16:04 UTC
The file /usr/local/bin/documentserver-update-securelink.sh contains a call to pwgen in line 38:

SECURE_LINK_SECRET=${SECURE_LINK_SECRET:-$(pwgen -s 20)}

But after installing OnlyOffice, pwgen is not installed. I had to run "pkg install pwgen". Maybe pwgen should be listed in the dependencies?
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-04-02 15:42:13 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=778a941e4850fc369480287665ad33086975bb0e

commit 778a941e4850fc369480287665ad33086975bb0e
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2023-04-02 13:29:08 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2023-04-02 15:40:57 +0000

    www/onlyoffice-documentserver: Add missing pwgen dependency

    It is required by documentserver-update-securelink.sh

    PR:             270589
    Reported by:    freebsd.org@vollkorn.cryptobitch.de

 www/onlyoffice-documentserver/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2023-04-02 15:42:39 UTC
Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-04-04 10:27:10 UTC
A commit in branch 2023Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=810506c43eb03cc31d7a509888dfa96eb50f98f3

commit 810506c43eb03cc31d7a509888dfa96eb50f98f3
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2023-04-02 13:29:08 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2023-04-04 10:25:45 +0000

    www/onlyoffice-documentserver: Add missing pwgen dependency

    It is required by documentserver-update-securelink.sh

    PR:             270589
    Reported by:    freebsd.org@vollkorn.cryptobitch.de

    (cherry picked from commit 778a941e4850fc369480287665ad33086975bb0e)

 www/onlyoffice-documentserver/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)