Bug 270661
| Summary: | taskqgroup_cpu_create does taskqueue_thread_enqueue not gtaskqueue_thread_enqueue | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Nick Reilly <nreilly> |
| Component: | kern | Assignee: | Mark Johnston <markj> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | aaron.styx, markj |
| Priority: | --- | ||
| Version: | CURRENT | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
Nick Reilly
2023-04-05 20:12:53 UTC
Hmm, and this also means that the check "enqueue == gtaskqueue_thread_enqueue" in _gtaskqueue_create() is always false... A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=e1f336704d308679d4178fd5063dba854b22a07b commit e1f336704d308679d4178fd5063dba854b22a07b Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2023-12-31 16:36:12 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2023-12-31 16:49:08 +0000 gtaskqueue: Fix a typo This is a no-op in practice since gtaskqueue_thread_enqueue() and taskqueue_thread_enqueue() are identical, and while _gtaskqueue_create() compares the enqueue callback pointer with gtaskqueue_thread_enqueue(), the result has no effect since TQ_FLAGS_UNLOCKED_ENQUEUE was copied directly from subr_taskqueue.c and is unused in the gtaskqueue code. Fix it anyway since it's a bug. More generally we really need to consolidate subr_taskqueue.c and subr_gtaskqueue.c. PR: 270661 MFC after: 1 week sys/kern/subr_gtaskqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=144e7a72f476f8f8453c40532c6f95c1f9add7ae commit 144e7a72f476f8f8453c40532c6f95c1f9add7ae Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2023-12-31 16:36:12 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2024-01-07 16:56:04 +0000 gtaskqueue: Fix a typo This is a no-op in practice since gtaskqueue_thread_enqueue() and taskqueue_thread_enqueue() are identical, and while _gtaskqueue_create() compares the enqueue callback pointer with gtaskqueue_thread_enqueue(), the result has no effect since TQ_FLAGS_UNLOCKED_ENQUEUE was copied directly from subr_taskqueue.c and is unused in the gtaskqueue code. Fix it anyway since it's a bug. More generally we really need to consolidate subr_taskqueue.c and subr_gtaskqueue.c. PR: 270661 MFC after: 1 week (cherry picked from commit e1f336704d308679d4178fd5063dba854b22a07b) sys/kern/subr_gtaskqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=c8bfd3fda78cd89cfc9d419a26946603c2124b10 commit c8bfd3fda78cd89cfc9d419a26946603c2124b10 Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2023-12-31 16:36:12 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2024-01-07 16:56:35 +0000 gtaskqueue: Fix a typo This is a no-op in practice since gtaskqueue_thread_enqueue() and taskqueue_thread_enqueue() are identical, and while _gtaskqueue_create() compares the enqueue callback pointer with gtaskqueue_thread_enqueue(), the result has no effect since TQ_FLAGS_UNLOCKED_ENQUEUE was copied directly from subr_taskqueue.c and is unused in the gtaskqueue code. Fix it anyway since it's a bug. More generally we really need to consolidate subr_taskqueue.c and subr_gtaskqueue.c. PR: 270661 MFC after: 1 week (cherry picked from commit e1f336704d308679d4178fd5063dba854b22a07b) sys/kern/subr_gtaskqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) |
