Bug 270693

Summary: mail/neomutt: make configure fails if lang/tcl85 is installed
Product: Ports & Packages Reporter: John Hein <jcfyecrayz>
Component: Individual Port(s)Assignee: Pietro Cerutti <gahr>
Status: Closed FIXED    
Severity: Affects Some People CC: bapt, gahr, tcltk
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/neomutt/neomutt/issues/3808
Attachments:
Description Flags
[patch] avoid tclsh8.5
none
[patch] v2: avoid tclsh8.5, fix stage-qa none

Description John Hein 2023-04-07 23:06:20 UTC 
If lang/tcl85 is installed, 'make -C mail/neomut' fails:

 .
 .
Checking for tokyocabinet ...1.4.48
Checking for a GSSAPI implementation...MIT
Created Makefile from Makefile.autosetup
Created config.h
Error: invalid command name "lmap"
===>  Script "configure" failed unexpectedly.
Please report the problem to bapt@FreeBSD.org [maintainer] and attach the
"/z1/local/users/jhein/wd/usr/ports/mail/neomutt/work/neomutt-20230322/config.log"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1
Comment 1 John Hein 2023-04-07 23:46:47 UTC 
Upstream bug report: https://github.com/neomutt/neomutt/issues/3808
Comment 2 John Hein 2023-04-07 23:50:49 UTC 
Created attachment 241344 [details]
[patch] avoid tclsh8.5

Remove support for tclsh8.5.

While here remove old NCURSES option from OPTIONS_DEFAULT.
Comment 3 John Hein 2023-04-09 11:45:22 UTC 
Created attachment 241373 [details]
[patch] v2: avoid tclsh8.5, fix stage-qa

Also 'make stage-qa' is showing errors:

Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'share/neomutt/oauth2/mutt_oauth2.py'
Error: '/usr/bin/env python3' is an invalid shebang you need USES=shebangfix for 'share/neomutt/account-command/macos-keychain/keychain.py'


This updated patch addresses that (adds to SHEBANG_FILES and add USES=python:env).

Also fix GSSAPI_NONE to explicitly disable gss rather than relying on any implicit default behavior.

Do some sorting / section ordering for things that were touched in this patch.  Optionally more such changes could be applied as suggested by portclippy & portfmt.
Comment 4 Pietro Cerutti freebsd_committer freebsd_triage 2023-04-11 06:32:20 UTC 
To bapt@ to comment on anything not related to Tcl8.5, for which you can pick https://github.com/neomutt/neomutt/pull/3819.
Comment 5 Pietro Cerutti freebsd_committer freebsd_triage 2023-04-11 08:54:02 UTC 
I'll take case of this :)
Comment 6 commit-hook freebsd_committer freebsd_triage 2023-04-11 15:54:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ac453ec468ecc9ad9a7f271c535dd485a6e412a4

commit ac453ec468ecc9ad9a7f271c535dd485a6e412a4
Author:     Pietro Cerutti <gahr@FreeBSD.org>
AuthorDate: 2023-04-11 15:52:23 +0000
Commit:     Pietro Cerutti <gahr@FreeBSD.org>
CommitDate: 2023-04-11 15:53:24 +0000

    mail/neomutt: fix build with tcl85 + shebang files

    PR:             270693
    Reported by:    John Hein <jcfyecrayz@liamekaens.com>

 mail/neomutt/Makefile               |  9 ++++--
 mail/neomutt/files/patch-lmap (new) | 58 +++++++++++++++++++++++++++++++++++++
 2 files changed, 65 insertions(+), 2 deletions(-)
Comment 7 Pietro Cerutti freebsd_committer freebsd_triage 2023-04-11 15:55:21 UTC 
I've fixed the build with tcl85 by picking https://github.com/neomutt/neomutt/pull/3819, added the configure option for GSS OFF, fixed the shebang files, and made sure prefix is passed (would fail port test otherwise).

I'll leave the aesthetics for bapt, if he's interested.