Bug 270765

Summary: net-p2p/qbittorrent: Adjust default settings when using libtorrent-rasterbar 2.x
Product: Ports & Packages Reporter: Daniel Engberg <diizzy>
Component: Individual Port(s)Assignee: Daniel Engberg <diizzy>
Status: Closed FIXED    
Severity: Affects Only Me Flags: yuri: maintainer-feedback+
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for qbittorrent
none
Patch for qbittorrent v2 none

Description Daniel Engberg freebsd_committer freebsd_triage 2023-04-11 12:52:54 UTC 
Created attachment 241422 [details]
Patch for qbittorrent

Disable memmory mapped file handling and use "POSIX-compliant"
Backport commit 8bcac1bed28f93c0712e915f43294b1e5fd03659 which reduces FilePoolSize

References:
https://github.com/qbittorrent/qBittorrent/commit/8bcac1bed28f93c0712e915f43294b1e5fd03659
https://github.com/arvidn/libtorrent/issues/6667#issuecomment-1502670412

This also seems to resolve the memory related issue on my test box
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-04-11 19:20:28 UTC 
Thanks for the patch.

Approved.

Please also don't forget to bump it.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2023-04-12 08:43:46 UTC 
Created attachment 241428 [details]
Patch for qbittorrent v2

Looks like my Makefile changes didn't go into the  previous patch...

Change desc for libtorrent-rasterbar v2 to experimental
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2023-04-12 11:01:15 UTC 
Friendly ping in case bugzilla didn't send you a mail...
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-04-25 09:06:28 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d9bf924e99dd21a80d29cae265fdfa2bf0b77486

commit d9bf924e99dd21a80d29cae265fdfa2bf0b77486
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-04-25 08:52:48 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-04-25 09:05:39 +0000

    net-p2p/qbittorrent: Adjust default settings when using libtorrent-rasterbar 2.x

    * Disable memmory mapped file handling and use "POSIX-compliant"
    * Backport commit 8bcac1bed28f93c0712e915f43294b1e5fd03659 which
      reduces FilePoolSize
    * Change status to experimental

    This change only applies to new installs, if you have a configuration
    already you need to apply these changes by hand

    References:
    https://github.com/qbittorrent/qBittorrent/commit/8bcac1bed28f93c0712e915f43294b1e5fd03659
    https://github.com/arvidn/libtorrent/issues/6667#issuecomment-1502670412

    PR:             270765
    Reviewed by:    yuri (previous revision)

 net-p2p/qbittorrent/Makefile                            |  3 ++-
 .../extrapatch-libtorrent-rasterbar2-settings (new)     | 17 +++++++++++++++++
 2 files changed, 19 insertions(+), 1 deletion(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2023-04-25 09:10:27 UTC 
Committed, thanks