Summary: | databases/postgresql13-client fails to build WITH_LLVM_BINUTILS (LLVM strip) | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Ed Maste <emaste> |
Component: | Individual Port(s) | Assignee: | pgsql |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | CC: | girgen |
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(pgsql) |
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any | ||
See Also: |
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270768 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265878 |
||
Bug Depends on: | |||
Bug Blocks: | 258872 |
Description
Ed Maste
![]() ![]() Submitted pgsql bug: BUG #17898: Build failure when strip is LLVM's version I think this should propagate upstreams, to the postgresql community. Right? Tom Lane replied and the change to use --strip-unneeded has been applied upstream: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=a14afd3bdc21c0c56401fb8cb2fce74f4b7dc446 I'm not sure what the timeline is for pgsql updates though, we might want to apply it as a local patch until the next update comes along? Yeah, I started the conversation upstreams, and it is now it is patched. We should make a local patch until the upstream change hits us. I'll handle that. :) I see that pgsql was updated in 3fd6f200dc8c12022515f7c3f662df148941e261, did it bring in the strip change? (In reply to Ed Maste from comment #6) I hae to check, but yes, the idea was that this was fixed upstreams. This was fixed upstreams with the latest patch release: commit 6dce37203410b011c0ccae40acf2649f79c38242 Author: Tom Lane <tgl@sss.pgh.pa.us> Date: Thu Apr 20 18:12:32 2023 -0400 Use --strip-unneeded when stripping static libraries with GNU strip. We've long used "--strip-unneeded" for shared libraries but plain "-x" for static libraries when stripping symbols with GNU strip. There doesn't seem to be any really good reason for that though, since --strip-unneeded produces smaller output (as "-x" alone does not remove debug symbols). Moreover it seems that llvm-strip, although it identifies as GNU strip, misbehaves when given "-x" for this purpose. It's unclear whether that's intentional or a bug in llvm-strip, but in any case it seems like changing to use --strip-unneeded in all cases should be a win. Note that this doesn't change our behavior when dealing with non-GNU strip. Per gripes from Ed Maste and Palle Girgensohn. Back-patch, in case anyone wants to use llvm-strip with stable branches. Discussion: https://postgr.es/m/17898-5308d09543463266@postgresql.org Discussion: https://postgr.es/m/20230420153338.bbj2g5jiyy3afhjz@awork3.anarazel.de |