Bug 270817
| Summary: | www/chromium: needs help to cope with icu-73.1 | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | david |
| Component: | Individual Port(s) | Assignee: | Robert Nagy <rnagy> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | fgorter, fullermd, iron.udjin, leres, robert, rozhuk.im |
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(chromium) |
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| Bug Depends on: | |||
| Bug Blocks: | 270422 | ||
|
Description
david
2023-04-13 16:23:37 UTC
I am looking into it. The same on 13.2-STABLE and 13.2-RELEASE with poudriere-3.3.7_1. https://reviews.freebsd.org/D39564 should fix it. devel/electron22 can use this exact same fix.
Getting build errors like:
;
../../third_party/icu/source/i18n/unicode/dtitvfmt.h:95:57: error: expected ';' at end of declaration list
UnicodeString toTempString(UErrorCode& status) const U_OVERRIDE;
^
;
../../third_party/icu/source/i18n/unicode/dtitvfmt.h:98:75: error: expected ';' at end of declaration list
Appendable &appendTo(Appendable& appendable, UErrorCode& status) const U_OVERRIDE;
^
;
../../third_party/icu/source/i18n/unicode/dtitvfmt.h:101:82: error: expected ';' at end of declaration list
UBool nextPosition(ConstrainedFieldPosition& cfpos, UErrorCode& status) const U_OVERRIDE;
Currently trying to compile electron22-22.3.5_1 from source.
To add to the relevance of being a similar error as with Chrome/Iridium/Ungoogled etc, more errors from electron22-22.3.5_1 building from source:
In file included from ../../base/i18n/timezone.cc:10:
../../third_party/icu/source/common/unicode/unistr.h:1909:48: error: expected ';' at end of declaration list
UnicodeString &operator=(UnicodeString &&src) U_NOEXCEPT;
^
;
../../third_party/icu/source/common/unicode/unistr.h:1916:34: error: expected ';' at end of declaration list
void swap(UnicodeString &other) U_NOEXCEPT;
^
;
../../third_party/icu/source/common/unicode/unistr.h:1925:45: error: expected ';' at end of declaration list
swap(UnicodeString &s1, UnicodeString &s2) U_NOEXCEPT {
Seems to be identical issue with ICU not playing nice with the build environment.
(In reply to Robert Nagy from comment #3) Works for me, as noted in the review above (for www/chromium). Thank you! A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f5487f8d23309891b6faacaa9eb517f97ece429d commit f5487f8d23309891b6faacaa9eb517f97ece429d Author: Robert Nagy <rnagy@FreeBSD.org> AuthorDate: 2023-04-13 19:36:28 +0000 Commit: Robert Nagy <rnagy@FreeBSD.org> CommitDate: 2023-04-14 09:19:33 +0000 www/{*chromium,iridium}: unbreak build with icu 73 PR: 270817 Approved by: rene (mentor) .../files/patch-build_linux_unbundle_icu.gn (new) | 18 ++++++++++++++++++ .../files/patch-build_linux_unbundle_icu.gn (new) | 18 ++++++++++++++++++ .../files/patch-build_linux_unbundle_icu.gn (new) | 18 ++++++++++++++++++ 3 files changed, 54 insertions(+) |
