Summary: | devel/electron22: build fails with icu 73.1 | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Stefan Ehmann <shoesoft> |
Component: | Individual Port(s) | Assignee: | Hiroki Tagato <tagattie> |
Status: | Closed FIXED | ||
Severity: | Affects Only Me | CC: | fgorter |
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(tagattie) |
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any | ||
Bug Depends on: | |||
Bug Blocks: | 270422 |
Description
Stefan Ehmann
2023-04-14 00:13:43 UTC
Having the same issues here: In file included from ../../base/i18n/timezone.cc:10: ../../third_party/icu/source/common/unicode/unistr.h:1909:48: error: expected ';' at end of declaration list UnicodeString &operator=(UnicodeString &&src) U_NOEXCEPT; ^ ; ../../third_party/icu/source/common/unicode/unistr.h:1916:34: error: expected ';' at end of declaration list void swap(UnicodeString &other) U_NOEXCEPT; ^ ; ../../third_party/icu/source/common/unicode/unistr.h:1925:45: error: expected ';' at end of declaration list swap(UnicodeString &s1, UnicodeString &s2) U_NOEXCEPT { << **snip** >> ; ../../third_party/icu/source/i18n/unicode/dtitvfmt.h:95:57: error: expected ';' at end of declaration list UnicodeString toTempString(UErrorCode& status) const U_OVERRIDE; ^ ; ../../third_party/icu/source/i18n/unicode/dtitvfmt.h:98:75: error: expected ';' at end of declaration list Appendable &appendTo(Appendable& appendable, UErrorCode& status) const U_OVERRIDE; ^ ; ../../third_party/icu/source/i18n/unicode/dtitvfmt.h:101:82: error: expected ';' at end of declaration list UBool nextPosition(ConstrainedFieldPosition& cfpos, UErrorCode& status) const U_OVERRIDE; Seems to be identical issue with ICU not playing nice with the build environment. There is an ICU fix already for Chromium / Iridium / Ungoogled-Chromium builds that suffered build failures due to pretty much the exact same reason. THAT fix can be found here & I can confirm it works for the browsers: https://reviews.freebsd.org/D39564 We need a similar patch that "translates" "U_FINAL=final" / "U_NOEXCEPT=noexcept" / "U_OVERRIDE=override" etc and whatever else ICU fettles with. (In reply to fgorter from comment #1) The patch at the URL is indeed applicable to devel/electron ports and fixes the build errors. I will update the ports accordingly. Thanks for the information. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=db5bfb69f45bcea3c912553657cd5c72ac984254 commit db5bfb69f45bcea3c912553657cd5c72ac984254 Author: Robert Nagy <rnagy@FreeBSD.org> AuthorDate: 2023-04-15 14:18:26 +0000 Commit: Hiroki Tagato <tagattie@FreeBSD.org> CommitDate: 2023-04-15 14:22:21 +0000 devel/electron{21,22}: fix build with icu 73 PR: 270827 Reported by: shoesoft@gmx.net, fgorter@gmail.com, jonc@chen.org.nz (via ports), jbeich (via ports), david@catwhisker.org (via ports) Obtained from: https://reviews.freebsd.org/D39564 .../files/patch-build_linux_unbundle_icu.gn (new) | 18 ++++++++++++++++++ .../files/patch-build_linux_unbundle_icu.gn (new) | 18 ++++++++++++++++++ 2 files changed, 36 insertions(+) Patch committed. Thanks for reporting! (In reply to Hiroki Tagato from comment #2) You're welcome! (I had intended to sit down & figure it out myself... you've saved me from a headache!) |