Bug 270893

Summary: security/py-notus-scanner: 22.4.5 is missing slackware module
Product: Ports & Packages Reporter: Trond Endrestøl <Trond.Endrestol>
Component: Individual Port(s)Assignee: Jose Alonso Cardenas Marquez <acm>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (acm)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description Trond Endrestøl 2023-04-17 10:42:29 UTC
During "service notus_scanner start" this happened:

Traceback (most recent call last):
  File "/usr/local/bin/notus-scanner", line 33, in <module>
    sys.exit(load_entry_point('notus-scanner==22.4.5', 'console_scripts', 'notus-scanner')())
  File "/usr/local/bin/notus-scanner", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/usr/local/lib/python3.9/importlib/metadata.py", line 86, in load
    module = import_module(match.group('module'))
  File "/usr/local/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/usr/local/lib/python3.9/site-packages/notus/scanner/daemon.py", line 27, in <module>
    from .loader import JSONAdvisoriesLoader
  File "/usr/local/lib/python3.9/site-packages/notus/scanner/loader/__init__.py", line 18, in <module>
    from .loader import AdvisoriesLoader
  File "/usr/local/lib/python3.9/site-packages/notus/scanner/loader/loader.py", line 21, in <module>
    from ..models.packages.package import PackageAdvisories
  File "/usr/local/lib/python3.9/site-packages/notus/scanner/models/packages/__init__.py", line 24, in <module>
    from .slackware import SlackPackage
ModuleNotFoundError: No module named 'notus.scanner.models.packages.slackware'
/usr/local/etc/rc.d/notus_scanner: WARNING: failed to start notus_scanner

It's most likely due to an incomplete pkg-plist.
This package was built by yours truly on our dedicated builder.

Package details:

# pkg info -dfr py39-notus-scanner
py39-notus-scanner-22.4.5
Name           : py39-notus-scanner
Version        : 22.4.5
Installed on   : Sun Apr  9 21:28:14 2023 CEST [Sun Apr  9 19:28:14 2023 UTC]
Origin         : security/py-notus-scanner
Architecture   : FreeBSD:13:*
Prefix         : /usr/local
Categories     : security python
Licenses       : AGPLv3
Maintainer     : acm@FreeBSD.org
WWW            : https://github.com/greenbone/notus-scanner
Comment        : scanner for creating results from local security checks
Annotations    :
        flavor         : py39
        repo_type      : binary
        repository     : builder01
Flat size      : 1.33MiB
Description    :
Notus Scanner detects vulnerable products in a system environment. The scanning
method is to evaluate internal system information. It does this very fast and
even detects currently inactive products because it does not need to interact
with each of the products.

To report about vulnerabilities, Notus Scanner receives collected system
information on the one hand and accesses the vulnerability information from the
feed service on the other. Both input elements are in table form: the system
information is specific to each environment and the vulnerability information
is specific to each system type.

Notus Scanner integrates into the Greenbone Vulnerability Management framework
which allows to let it scan entire networks within a single task. Any
vulnerability test in the format of .notus files inside the Greenbone Feed will
be considered and automatically matched with the scanned environments.

WWW: https://github.com/greenbone/notus-scanner
Depends on     :
        py39-tomli-2.0.1_2
        py39-psutil-5.9.4
        py39-python-gnupg-0.4.7
        py39-paho-mqtt-1.6.1
        mosquitto-2.0.15_1
        python39-3.9.16_2
        py39-setuptools-63.1.0
        py39-sentry-sdk-1.5.12
        py39-packaging-23.0_2
Required by    :
        gvm-22.4.1
Comment 1 commit-hook freebsd_committer freebsd_triage 2023-04-17 18:41:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=18cb18865d8701ebdec9bb473e3260d96f99ae04

commit 18cb18865d8701ebdec9bb473e3260d96f99ae04
Author:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
AuthorDate: 2023-04-17 18:39:32 +0000
Commit:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
CommitDate: 2023-04-17 18:39:32 +0000

    security/py-notus-scanner: Fix pkg-plist file

    PR:             270893
    Reported by:    Trond.Endrestol@ _at_ ximalas.info

 security/py-notus-scanner/pkg-plist | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 2 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2023-04-17 18:41:37 UTC
Committed thanks!
Comment 3 Trond Endrestøl 2023-04-18 07:05:25 UTC
(In reply to Jose Alonso Cardenas Marquez from comment #2)
You should bump PORTREVISION to force a rebuild as the previously built package was successfully built, but incomplete.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-04-18 14:52:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=df05e7c3412b239a8502e83b7f597788a98013b4

commit df05e7c3412b239a8502e83b7f597788a98013b4
Author:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
AuthorDate: 2023-04-18 14:47:25 +0000
Commit:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
CommitDate: 2023-04-18 14:51:06 +0000

    security/py-notus-scanner: Bump PORTREVISION because a package with incomplete files was built

    PR:             270893
    Reported by:    Trond.Endrestol  __at___ ximalas.info

 security/py-notus-scanner/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 5 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2023-04-18 14:57:09 UTC
(In reply to Trond.Endrestol from comment #3)
Done, thanks!