Bug 271092
| Summary: | sysutils/flashrom: update to 1.3 caused missing INTERNAL_CONFIG option | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Franco Fichtner <franco> | ||||||
| Component: | Individual Port(s) | Assignee: | Michael Zhilin <mizhka> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(mizhka) |
||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=802567d7f842ae4470c64988a72e51948b133657 commit 802567d7f842ae4470c64988a72e51948b133657 Author: Michael Zhilin <mizhka@FreeBSD.org> AuthorDate: 2023-04-27 11:36:07 +0000 Commit: Michael Zhilin <mizhka@FreeBSD.org> CommitDate: 2023-04-27 12:35:56 +0000 sysutils/flashrom: change buildtool to meson Change buildtool to meson and remove redundant bits This commit is caused by ticket 271092 "update to 1.3 caused missing INTERNAL_CONFIG option". The aim is to involve meson tool for configure and installation parts. Reported by: franco@opnsense.org PR: 271092 sysutils/flashrom/Makefile | 15 +++++---------- sysutils/flashrom/pkg-plist (new) | 8 ++++++++ 2 files changed, 13 insertions(+), 10 deletions(-) Hi Franco, Thank you for your report. I couldn't find linuxism that disabled internal programmer. The port was required slight rework to use meson for configuration and installation parts. Could you please check 1.3.0_1 and if internal programmer is still not available, send log of port build? Best regards, Michael Hi Michael, The issue is in this commit... https://github.com/flashrom/flashrom/commit/8f39fd60549 > Enable the internal programmer on x86 or linux. So I don't think this will fix it. I can try tomorrow perhaps. Cheers, Franco Created attachment 241790 [details]
patch to enable all archs for freebsd flashrom
What is architecture of your machine?
Here is patch to enable build for all archs on freebsd.
Could you please check it as well?
It's a plain amd64 build. Let me check these now... Cheers, Franco For some reason 802567d7f842ae4470c64988a72e51948b133657 brings back the internal programmer to the standard build so the other patch is not necessary/easily verifiable from my end. You can consider this fixed. Thanks a lot! Cheers, Franco Excellent. Thank you for your report! |
Created attachment 241782 [details] INTERNAL_CONFIG patch Hi, The update to 1.3 includes a Linux-ism fail that disabled the INTERNAL_CONFIG option in FreeBSD port making flashing roms fail in our use cases. The patch puts it back and makes sure that required flags are being provided. Cheers, Franco