Bug 271100

Summary: net/activemq: Version update, explict jdk specification and rc script bug fixes
Product: Ports & Packages Reporter: James Elstone <james>
Component: Individual Port(s)Assignee: Fernando Apesteguía <fernape>
Status: Closed FIXED    
Severity: Affects Many People CC: fernape, freebsd, haemmerle, java, vvd
Priority: --- Keywords: easy, patch-ready, security
Version: LatestFlags: james: merge-quarterly?
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Update of the existing net/activemq port
james: maintainer-approval+
Patch for the port update. none

Description James Elstone 2023-04-27 15:08:07 UTC 
Made multiple changes, allowing a fresh installation to work out of the box, as well as an upgrade working OK.

Makefile:
 - Bumped to version 5.18.1
 - Added maintainer information
 - Specified version of openJDK to use
 - Updated initial audit.log and activemq.log to match thoses set in /etc/rc.conf
 - Removed .orig file deletion of non-existant file

distinfo:
 - Updated checksum for new distfile

files/activemq: (activemq rc.d startup file)
 - Added explict JAVA_HOME path to use, and defaulted to java/openjdk18
 - Added rc.conf tunable to allow the full java command to be echoed on stdout on service start (debuging for people not so familiar with activemq and how it is envoked)
 - Added audit logging to be turned on by default, with explaination in rc file.
 - Added Jolokia configuration file path to activemq invokation, supressing null pointer error on start-up
Comment 1 Mina Galić freebsd_triage 2023-04-27 15:24:01 UTC 
(In reply to James Elstone from comment #0)
did you perhaps forget to upload the patch?
Comment 2 James Elstone 2023-04-27 15:24:58 UTC 
Created attachment 241791 [details]
Update of the existing net/activemq port

Added myself as the maintainer going forwards.
Comment 3 James Elstone 2023-04-27 15:30:56 UTC 
(In reply to Mina Galić from comment #1)
Yes, An error between the seat and the desk occured. Shard file now attached for completeness.
Comment 4 James Elstone 2023-04-27 16:11:17 UTC 
Created attachment 241792 [details]
Patch for the port update.

Added git generated diff.
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2023-04-29 18:12:15 UTC 
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.


Thanks!
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2023-04-29 18:14:46 UTC 
^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2023-04-30 12:05:07 UTC 
Commmitted,

Thanks!
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-04-30 12:05:59 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a6345cef112d74fd440a25cdbb68733fe1bf6c4d

commit a6345cef112d74fd440a25cdbb68733fe1bf6c4d
Author:     James Elstone <james@elstone.net>
AuthorDate: 2023-04-29 18:06:44 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2023-04-30 11:59:53 +0000

    net/activemq: update to 5.18.1

    Reporter becomes maintainer. Already maintainer of some ports.

    Makefile:
     * Bumped to version 5.18.1
     * Added maintainer information
     * Specified version of openJDK to use
     * Updated initial audit.log and activemq.log to match thoses set in
       /etc/rc.conf
     * Removed .orig file deletion of non-existant file

    distinfo:
     * Updated checksum for new distfile

    files/activemq: (activemq rc.d startup file)
     * Added explict JAVA_HOME path to use, and defaulted to java/openjdk18
     * Added rc.conf tunable to allow the full java command to be echoed on stdout
       on service start (debuging for people not so familiar with activemq and how
       it is envoked)
     * Added audit logging to be turned on by default, with explaination in rc file.
     * Added Jolokia configuration file path to activemq invokation, supressing
       null pointer error on start-up

    PR:             271100
    Reported by:    james@elstone.net

 net/activemq/Makefile          |  8 +++---
 net/activemq/distinfo          |  6 ++---
 net/activemq/files/activemq.in | 57 ++++++++++++++++++++++++++++++++++--------
 3 files changed, 55 insertions(+), 16 deletions(-)
Comment 9 Ronald Klop freebsd_committer freebsd_triage 2024-09-03 09:47:18 UTC 
*** Bug 266099 has been marked as a duplicate of this bug. ***
Comment 10 Vladimir Druzenko freebsd_committer freebsd_triage 2024-12-31 12:31:20 UTC 
> * Added explict JAVA_HOME path to use, and defaulted to java/openjdk18
Why?

5.18.1: "Java compatibility: 11+"
https://activemq.apache.org/components/classic/download/classic-05-18-01

5.18.3: "fix on JDK17+ support"
https://activemq.apache.org/components/classic/download/classic-05-18-03

6+: "JDK17/20/21 support" and "Java compatibility: 17+"
https://activemq.apache.org/components/classic/download/classic-06-00-00