Bug 271172
| Summary: | security/openssh-portable does not build on i386 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | mike | ||||||
| Component: | Individual Port(s) | Assignee: | Bryan Drewery <bdrewery> | ||||||
| Status: | Closed Overcome By Events | ||||||||
| Severity: | Affects Some People | CC: | bdrewery, emaste, freebsd, fuz | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | i386 | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
0{nano13-i386}# cc -v
FreeBSD clang version 15.0.7 (https://github.com/llvm/llvm-project.git llvmorg-15.0.7-0-g8dfdcc7b7bf6)
Target: i386-unknown-freebsd13.2
Thread model: posix
InstalledDir: /usr/bin
0{nano13-i386}# uname -a
FreeBSD nano13-i386.sentex.ca 13.2-STABLE FreeBSD 13.2-STABLE stable/13-3a52cc4445 GENERIC i386
0{nano13-i386}#
can you please rebuild with MAKE_JOBS_UNSAFE=yes in make.conf(5) this tells make to not parallelize this build and report back if it succeeds or not Thanks, it still fails.
...
EP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c sshkey-xmss.c -o sshkey-xmss.o
cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c xmss_commons.c -o xmss_commons.o
cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c xmss_fast.c -o xmss_fast.o
cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c xmss_hash.c -o xmss_hash.o
cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c xmss_hash_address.c -o xmss_hash_address.o
cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c xmss_wots.c -o xmss_wots.o
cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c authfd.c -o authfd.o
cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c authfile.c -o authfile.o
cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c canohost.c -o canohost.o
cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c channels.c -o channels.o
channels.c:2561:12: error: comparison of integers of different signs: 'time_t' (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare]
now >= c->lastused + c->inactive_deadline) {
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
*** Error code 1
Stop.
make[2]: stopped in /usr/ports/security/openssh-portable/work-default/openssh-9.2p1
*** Error code 1
Stop.
make[1]: stopped in /usr/ports/security/openssh-portable
*** Error code 1
Stop.
make: stopped in /usr/ports/security/openssh-portable
1{nano13-i386}#
FYI, still not able to build with the new version still on i386
l -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c xmss_hash_address.c -o xmss_hash_address.o
cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c xmss_wots.c -o xmss_wots.o
cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c authfd.c -o authfd.o
cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c authfile.c -o authfile.o
cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c canohost.c -o canohost.o
cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memset -fstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c channels.c -o channels.o
channels.c:2569:12: error: comparison of integers of different signs: 'time_t' (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare]
now >= c->lastused + c->inactive_deadline) {
~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
*** Error code 1
Stop.
make[2]: stopped in /usr/ports/security/openssh-portable/work-default/openssh-9.3p1
*** Error code 1
Stop.
make[1]: stopped in /usr/ports/security/openssh-portable
*** Error code 1
Stop.
make: stopped in /usr/ports/security/openssh-portable
1{nano13-i386}#
I guess the question is, what is the safest way to cast this line ?
channels.c:2569:12: error: comparison of integers of different signs: 'time_t' (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare]
now >= c->lastused + c->inactive_deadline) {
Changing it to
now >= (time_t) c->lastused + (time_t) c->inactive_deadline) {
will let it compile, but will this break things ?
Created attachment 242536 [details]
possible patch for the ports
putting patch-channels.c in files/ is compile tested on i386 and amd64 and seems to work. Not sure if something somewhere else also needs fixing
I'm somewhat surprised this isn't failing on other 32 bit platforms Created attachment 242538 [details] second version of patch It was suggested on the ssh mailing list that I get rid of the ifdef and just force the cast Compile / build and run tested on i386 and amd64 https://lists.mindrot.org/pipermail/openssh-unix-dev/2023-June/040782.html > I'm somewhat surprised this isn't failing on other 32 bit platforms
i386 is our only platform with 32-bit time_t
Assign to maintainer. Port was not auto-assigned due to wrong category in title. this is fixed in later versions. you can close now I would say.... Thank you for following up. |
--- port-net.o --- cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memstack-protector-strong -Werror -fPIC -I. -I.. -I. -I./.. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DHAVE_CONFIG_H -c port-net.c --- port-uw.o --- cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memstack-protector-strong -Werror -fPIC -I. -I.. -I. -I./.. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DHAVE_CONFIG_H -c port-uw.c --- channels.o --- channels.c:2561:12: error: comparison of integers of different signs: 'time_t' (aka 'int') and 'unsigned int' [-Werror,-Wsign-compare] --- openbsd-compat/libopenbsd-compat.a --- --- libopenbsd-compat.a --- ar rv libopenbsd-compat.a bsd-asprintf.o bsd-closefrom.o bsd-cygwin_util.o bsd-err.o bsd-flock.o bsd-getentropy.o bsd-getline.o bsd-getpagesize.o bsd-getpeereid.o bsd-malloc.o bsd-misc.o bsd-nextstep.o bsd-openpty.o bsd-poll.o bsd-pselect.o bsd-setres_id.o bsd-signal.o bsd-snprintf.o bsd-statvfs.o bsd-timegm.o bsd-waitpid.o fake-rfc2553.o getrrsetbyname-ldns.o kludge-fd_set.o openssl-compat.o libressl-api-compat.o xcrypt.o arc4random.o arc4random_uniform.o base64.o basename.o bcrypt_pbkdf.o bindresvport.o blowfish.o daemon.o dirname.o explicit_bzero.o fmt_scaled.o freezero.o fnmatch.o getcwd.o getgrouplist.o getopt_long.o getrrsetbyname.o glob.o inet_aton.o inet_ntoa.o inet_ntop.o md5.o memmem.o mktemp.o pwcache.o readpassphrase.o reallocarray.o recallocarray.o rresvport.o setenv.o setproctitle.o sha1.o sha2.o sigact.o strcasestr.o strlcat.o strlcpy.o strmode.o strndup.o strnlen.o strptime.o strsep.o strtoll.o strtonum.o strtoull.o strtoul.o timingsafe_bcmp.o vis.o port-aix.o port-irix.o port-linux.o port-prngd.o port-solaris.o port-net.o port-uw.o ar: warning: creating libopenbsd-compat.a a - bsd-asprintf.o a - bsd-closefrom.o a - bsd-cygwin_util.o a - bsd-err.o a - bsd-flock.o a - bsd-getentropy.o a - bsd-getline.o a - bsd-getpagesize.o a - bsd-getpeereid.o a - bsd-malloc.o a - bsd-misc.o a - bsd-nextstep.o a - bsd-openpty.o a - bsd-poll.o a - bsd-pselect.o a - bsd-setres_id.o a - bsd-signal.o a - bsd-snprintf.o a - bsd-statvfs.o a - bsd-timegm.o a - bsd-waitpid.o a - fake-rfc2553.o a - getrrsetbyname-ldns.o a - kludge-fd_set.o a - openssl-compat.o a - libressl-api-compat.o a - xcrypt.o a - arc4random.o a - arc4random_uniform.o a - base64.o a - basename.o a - bcrypt_pbkdf.o a - bindresvport.o a - blowfish.o a - daemon.o a - dirname.o a - explicit_bzero.o a - fmt_scaled.o a - freezero.o a - fnmatch.o a - getcwd.o a - getgrouplist.o a - getopt_long.o a - getrrsetbyname.o a - glob.o a - inet_aton.o a - inet_ntoa.o a - inet_ntop.o a - md5.o a - memmem.o a - mktemp.o a - pwcache.o a - readpassphrase.o a - reallocarray.o a - recallocarray.o a - rresvport.o a - setenv.o a - setproctitle.o a - sha1.o a - sha2.o a - sigact.o a - strcasestr.o a - strlcat.o a - strlcpy.o a - strmode.o a - strndup.o a - strnlen.o a - strptime.o a - strsep.o a - strtoll.o a - strtonum.o a - strtoull.o a - strtoul.o a - timingsafe_bcmp.o a - vis.o a - port-aix.o a - port-irix.o a - port-linux.o a - port-prngd.o a - port-solaris.o a - port-net.o a - port-uw.o ranlib libopenbsd-compat.a --- channels.o --- now >= c->lastused + c->inactive_deadline) { ~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- cipher.o --- cc -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -pipe -Wunknown-warning-option -Qunused-arguments -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign -Wno-unused-result -Wmisleading-indentation -Wbitwise-instead-of-logical -fno-strict-aliasing -mretpoline -D_FORTIFY_SOURCE=2 -ftrapv -fzero-call-used-regs=all -fno-builtin-memstack-protector-strong -Werror -I. -I. -isystem /usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include/editline -I/usr/local/include -DSSHDIR=\"/usr/local/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/bin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/local/libexec/ssh-pkcs11-helper\" -D_PATH_SSH_SK_HELPER=\"/usr/local/libexec/ssh-sk-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c cipher.c -o cipher.o --- channels.o --- 1 error generated. *** [channels.o] Error code 1 make[2]: stopped in /usr/ports/security/openssh-portable/work-default/openssh-9.2p1 1 error make[2]: stopped in /usr/ports/security/openssh-portable/work-default/openssh-9.2p1 ===> Compilation failed unexpectedly. Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to the maintainer. *** Error code 1 Stop. make[1]: stopped in /usr/ports/security/openssh-portable *** Error code 1 Stop. make: stopped in /usr/ports/security/openssh-portable