Bug 271175
| Summary: | */*: Treewide, move users of libebur128 to ebur128 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Daniel Engberg <diizzy> | ||||
| Component: | Individual Port(s) | Assignee: | Daniel Engberg <diizzy> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | acm, daniel, jhale, kde, tcberner | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Moin moin It might make sense to do something similar as with librsvg2 to allow choosing rust/legacy via default-versions, if this is the first rust-port in this dependency chain. mfg Tobias Not sure if it's worth it? audio/cantata pulls in X and friends like audio/mixxx audio/libgroove is on life support upstream being optimistic (also depends on ffmpeg) audio/mixxx and audio/mixxx22 pulls in X and friends so you're likely to use librsvg2 audio/pulseeffects is abandoned upstream, easyeffects is the new project name and targets pipewire audio/rsgain depending on configuration of ffmpeg ebur128 might be the first user to pull in rust A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4cd440845e24202042e8b35a1c1db08a928b5946 commit 4cd440845e24202042e8b35a1c1db08a928b5946 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2023-05-02 21:35:15 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2023-05-02 21:35:19 +0000 */*: Move consumers of libebur128 to ebur128 ebur128 provides a noticable faster implementation on at least aarch64 and amd64 so make it default treewide as they conflict. If there's a need further down the road we can add an option to choose between. PR: 271175 Approved by: acm, jhale (maintainers of some of the ports) Sponsored by: Blinkinblox audio/cantata/Makefile | 4 ++-- audio/libgroove/Makefile | 4 ++-- audio/mixxx/Makefile | 4 ++-- audio/mixxx22/Makefile | 4 ++-- audio/pulseeffects/Makefile | 4 ++-- audio/rsgain/Makefile | 3 ++- 6 files changed, 12 insertions(+), 11 deletions(-) Forgot to add, jhale acked via private email. |
Created attachment 241910 [details] Treewide patch The rust port on my boxes performs about 15% or better on amd64 and aarch64 so I think it makes sense to make it the default variant. Runtime tested with rsgain