Summary: | textproc/augeas: fix build with clang 16 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Dimitry Andric <dim> | ||||||
Component: | Individual Port(s) | Assignee: | FreeBSD Puppet Team <puppet> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | freebsd | ||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(puppet) |
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 271047 | ||||||||
Attachments: |
|
Description
Dimitry Andric
2023-05-08 17:01:53 UTC
Created attachment 242062 [details]
textproc/augeas: fix build with clang 16
I know your last pull request hasn't been merged upstream yet, but would you still try to submit this upstream? (In reply to Mina Galić from comment #2) Ah, I didn't check upstream but it's already fixed there: https://github.com/hercules-team/augeas/pull/792 Created attachment 242108 [details]
textproc/augeas: fix build with clang 16
Update patch to apply the upstream fix instead.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=67237e5afd193f57fb2153072d01d6645eb79b5c commit 67237e5afd193f57fb2153072d01d6645eb79b5c Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2023-05-08 08:37:41 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2023-05-18 11:33:25 +0000 textproc/augeas: fix build with clang 16 Clang 16 has a new error about incompatible integer to pointer conversions, which shows up when building textproc/augeas: augprint.c:1477:24: warning: call to undeclared function 'basename'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] char *program_name = basename(argv[0]); ^ augprint.c:1477:9: error: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *program_name = basename(argv[0]); ^ ~~~~~~~~~~~~~~~~~ This is because basename(3) is declared in <libgen.h>, but augprint.c does not include it. Upstream has already fixed this, so apply the commit until there is a new release. PR: 271316 Approved by: portmgr (build fix blanket) MFH: 2023Q2 textproc/augeas/Makefile | 4 ++++ textproc/augeas/distinfo | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) |