Bug 271452
| Summary: | security/crowdsec-firewall-bouncer: update to 0.0.27 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | marco | ||||
| Component: | Individual Port(s) | Assignee: | Robert Clausecker <fuz> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | fuz | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://github.com/crowdsecurity/cs-firewall-bouncer/releases/tag/v0.0.27 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 271459 | ||||||
| Attachments: |
|
||||||
Will change
GH_TAGNAME= ${DISTVERSIONFULL}-freebsd
to
DISTVERSIONSUFFIX= -freebsd
on commit.
Check if you can perhaps redesign the port to also use FreeBSD's default Go build targets instead of your own makefile. This way, you won't have to fetch and vendor dependencies.
Also, as per policy please do not use REINPLACE_CMD for static replacements. Instead, supply a patch file.
Please also check if a build dependency on git is really needed. I already see that you have correctly patched the build tag to not reference git, but once you did that, I don't see where the port requires git anymore.
Update looks good otherwise. Would you like me to commit as is or do you want to improve the patch?
(In reply to Robert Clausecker from comment #1) Hi Robert, thanks for the review. While I would love to use the Go build macros, I did not find a way to apply them to the main crowdsec package, with several binaries and plugins. Bouncers are simpler so it makes a lot of sense. For now I'd like the patch to be applied as is, when I have some time I'll follow your other suggestions and give another try with the Go macros. By the way I just opened an issue for crowdsec 1.5.0: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271459 Thanks again! Will commit with my next batch. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=f69368cdae663408d8d317a382bb0387429289c5 commit f69368cdae663408d8d317a382bb0387429289c5 Author: Marco Mariani <marco@crowdsec.net> AuthorDate: 2023-05-10 09:48:37 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2023-05-18 08:19:49 +0000 security/crowdsec-firewall-bouncer: update to 0.0.27 Drop now upstreamed patches. Relevant upstream change: greatly improved performance when syncing blocklists with the central API. Changelog: https://github.com/crowdsecurity/cs-firewall-bouncer/releases/tag/v0.0.27 PR: 271452 security/crowdsec-firewall-bouncer/Makefile | 22 +- security/crowdsec-firewall-bouncer/distinfo | 8 +- .../files/crowdsec_firewall.in | 3 +- .../files/patch-Makefile (gone) | 15 - .../files/patch-go.mod (gone) | 69 ---- .../files/patch-go.sum (gone) | 369 --------------------- .../files/patch-vendor_modules.txt (gone) | 187 ----------- .../files/pkg-deinstall.in | 4 +- .../crowdsec-firewall-bouncer/files/pkg-message.in | 10 +- 9 files changed, 18 insertions(+), 669 deletions(-) Thank you for your submission. |
Created attachment 242213 [details] patch for crowdsec-firewall-bouncer 0.0.27 Upstream update, I reverted the vendor patches since they were not required anymore. The main change concerning FreeBSD is greatly improved performance when syncing blocklists with the central API.