Bug 271513
| Summary: | cad/pcb-rnd: update to 3.1.0 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | hasdal <hasdalcodes> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Wen Heping <wen> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | fuz, wen | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Bug Depends on: | 271512 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
Thank you for taking this up. Have you tested this update? Can you provide a changelog? Please also provide a patch for the distinfo file. Created attachment 242374 [details] added the distinfo patch change log : http://www.repo.hu/projects/pcb-rnd/releases/changelog-3.1.0.txt Thanks for your patience Your patch file is malformed. Please check and resubmit. Ideally, make a commit and then produce a patch with git-format-patch and submit that. Created attachment 242395 [details]
fixed the malformed patch file
my mistake, I added a space while copying, now hopefully it is okay, I wanted to point out that it depends on the new updated version of lib-rnd which i submitted a patch for too for version 4.0.1, waiting for your your feedback, also if you could point out, if its okay to use diff command to generate the patch files or should I use "make a commit and then produce a patch with git-format-patch" and if so, should I make a git repository for the port for my development or what is the best way to manage that. Thanks as always.
It's best if you work on the FreeBSD ports tree as a git repository. Clone the ports tree, perform your changes, make a local commit and submit the commit as produced by git-format-patch. Make sure to always have your ports tree up to date when producing the patch in case someone else has touched the port. It is also permissible to just use a recursive diff, but it's more work for the committer and more likely that you make a mistake producing the diff and that it doesn't apply. I've added the other PR as a blocker. This patch was doctored and did not apply as is. I managed to fix it though. Make sure to submit patches exactly as they come from git! Do not copy-edit or modify them in any way! Your patch has a bunch of problems in the stage-qa phase. Please check and resubmit: ====> Running Q/A tests (stage-qa) Error: /usr/local/bin/gsch2pcb-rnd is linked to /usr/local/lib/libxml++-2.6.so.2 from textproc/libxml++26 but it is not declared as a dependency Warning: you need USE_GNOME+=libxml++26 Error: /usr/local/bin/gsch2pcb-rnd is linked to /usr/local/lib/libglibmm-2.4.so.1 from devel/glibmm but it is not declared as a dependency Warning: you need USE_GNOME+=glibmm Error: /usr/local/bin/gsch2pcb-rnd is linked to /usr/local/lib/libgobject-2.0.so.0 from devel/glib20 but it is not declared as a dependency Warning: you need USE_GNOME+=glib20 Error: /usr/local/bin/gsch2pcb-rnd is linked to /usr/local/lib/libglib-2.0.so.0 from devel/glib20 but it is not declared as a dependency Warning: you need USE_GNOME+=glib20 Error: /usr/local/bin/gsch2pcb-rnd is linked to /usr/local/lib/libintl.so.8 from devel/gettext-runtime but it is not declared as a dependency Warning: you need USES+=gettext-runtime Error: /usr/local/bin/gsch2pcb-rnd is linked to /usr/local/lib/libsigc-2.0.so.0 from devel/libsigc++20 but it is not declared as a dependency Warning: you need USE_GNOME+=libsigc++20 Created attachment 242527 [details]
patch for upgrade to 3.1.0
Thanks for the feedback, I just ran Make stage-qa and it reported no errors. can you please help me reproduce those errors so I can work on them. Thanks.
(In reply to hasdal from comment #8) Hm... that sounds like there is some wonky dependency stuff going on. I.e. pcb-rnd tries to auto-detect which dependencies are present and not all of them are declared correctly. A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=47eb8c2f7678cba3252694b973f1c9d2037cb8f0 commit 47eb8c2f7678cba3252694b973f1c9d2037cb8f0 Author: hasdal <hasdalcodes@gmail.com> AuthorDate: 2023-05-19 06:34:00 +0000 Commit: Wen Heping <wen@FreeBSD.org> CommitDate: 2023-06-17 08:16:59 +0000 cad/pcb-rnd: Update to 3.1.1 Pass maintainership to submitter PR: 271513 Reported by: hasdalcodes@gmail.com cad/pcb-rnd/Makefile | 4 ++-- cad/pcb-rnd/distinfo | 6 +++--- cad/pcb-rnd/pkg-plist | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 64 insertions(+), 5 deletions(-) |
Created attachment 242281 [details] patch for Makefile upgrade to 3.1.0 patch for upgrade to 3.1.0