Bug 271545

Summary: games/instead: enable HARFBUZZ by default after sdl2_ttf2 update to 2.0.18
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (amdmi3)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
v1 (apply via "git am") none

Description Jan Beich freebsd_committer freebsd_triage 2023-05-21 01:21:29 UTC 
Created attachment 242306 [details]
v1 (apply via "git am")

After ports 68d149ef6d4c harfbuzz is indirectly required via sdl2_ttf

$ pkg install portfmt
$ portscan -p . games/instead
[100%] finished in 0s
V       games/instead                            HARFBUZZ_CMAKE_BOOL
V       games/instead                            HARFBUZZ_DESC
V       games/instead                            HARFBUZZ_LIB_DEPENDS
Vc      games/instead                            LUAJIT_LIB_DEPENDS

Note, LUAJIT_LIB_DEPENDS is out of scope but can be fixed by switching to USES=luajit.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2023-05-22 18:27:56 UTC 
> Note, LUAJIT_LIB_DEPENDS is out of scope but can be fixed by switching to USES=luajit.

Not really, `Vc` status denotes variables set multiple times, not unused ones. But yes, we should switch to USES=luajit. I'm also not enabling HARFBUZZ by default to match upstream setting.
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-05-22 18:28:06 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=79e392c15d25a7fac189d22fe2d0c59585306f4f

commit 79e392c15d25a7fac189d22fe2d0c59585306f4f
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2023-05-22 15:41:29 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2023-05-22 18:27:10 +0000

    games/instead: enable harfbuzz support, fix lua(jit) deps

    - Enable harfbuzz support which is now available in SDL2_ttf (disabled
      by default according to upstream setting) [1]
    - Switch luajit dependency to USES=luajit (it also should now work on
      powerpc, so a related hack is no longer needed)
    - Fix dependency on lua
    - Remove no longer needed CMake argument

    PR:             271545 [1]
    Reported by:    jbeich [1]

 games/instead/Makefile | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)