Bug 271561

Summary: lang/lua54: Update to 5.4.6
Product: Ports & Packages Reporter: Andrew "RhodiumToad" Gierth <andrew>
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Many People CC: fuz, russ.haley
Priority: --- Flags: fuz: maintainer-feedback-
andrew: maintainer-feedback?
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Update lang/lua54 to 5.4.6 fuz: maintainer-approval+

Description Andrew "RhodiumToad" Gierth 2023-05-22 12:26:52 UTC
Created attachment 242324 [details]
Update lang/lua54 to 5.4.6

5.4.6 fixes a number of bugs in Lua 5.4.

(If Russ times out or defers, I offer to take maintainership of lang/lua53 and lang/lua54.)
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-06-04 12:38:22 UTC
Do you have a changelog for this update?
Comment 2 Andrew "RhodiumToad" Gierth 2023-06-04 13:31:15 UTC
(In reply to Robert Clausecker from comment #1)

5.4.6 fixes the following bugs in 5.4.4 and 5.4.5:

Lua 5.4.5:
    Changing the signature of 'lua_resetthread' broke ABI.

Lua 5.4.4:
    lua.c assumes that argv has at least one element.
    Lua can generate wrong code when _ENV is <const>.
    Wrong code generation for constants in bitwise operations. 
    Lua-stack overflow when C stack overflows while handling an error.
    'lua_settop' may use a pointer to stack invalidated by 'luaF_close'.
    'break' may not properly close variable in a 'for' loop. 
    GC not setting a proper target for next cycle after a full collection in generational mode.
    'utf8.codes' does not raise an error on spurious continuation bytes.
    C-stack overflow with deep nesting of coroutine.close.
    Wrong line in error message for arithmetic errors.
    Loading a corrupted binary file can segfault.

In addition some improvements have been made to the manual.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-06-07 07:58:56 UTC
Maintainership granted due to consecutive maintainer timeouts.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2023-06-07 07:59:07 UTC
Comment on attachment 242324 [details]
Update lang/lua54 to 5.4.6

Maintainer timeout.
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-06-08 11:36:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b4c88d1e7141e4bfcd2a9651fc24922b5b1556fe

commit b4c88d1e7141e4bfcd2a9651fc24922b5b1556fe
Author:     Andrew "RhodiumToad" Gierth <andrew@tao11.riddles.org.uk>
AuthorDate: 2023-06-07 07:56:57 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-06-08 10:51:06 +0000

    lang/lua54: update to 5.4.6

    Submitter becomes maintainer.

    5.4.6 fixes the following bugs in 5.4.4 and 5.4.5:

    Lua 5.4.5:
        Changing the signature of 'lua_resetthread' broke ABI.

    Lua 5.4.4:
        lua.c assumes that argv has at least one element.
        Lua can generate wrong code when _ENV is <const>.
        Wrong code generation for constants in bitwise operations.
        Lua-stack overflow when C stack overflows while handling an error.
        'lua_settop' may use a pointer to stack invalidated by 'luaF_close'.
        'break' may not properly close variable in a 'for' loop.
        GC not setting a proper target for next cycle after a full collection in generational mode.
        'utf8.codes' does not raise an error on spurious continuation bytes.
        C-stack overflow with deep nesting of coroutine.close.
        Wrong line in error message for arithmetic errors.
        Loading a corrupted binary file can segfault.

    In addition some improvements have been made to the manual.

    PR:             271561
    Approved by:    russ.haley@gmail.com (maintainer timeout, two weeks)

 lang/lua54/Makefile | 4 ++--
 lang/lua54/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-06-08 11:37:46 UTC
Thank you for your submission.