Bug 271829

Summary: shells/fish: re-add groff dependency
Product: Ports & Packages Reporter: Mina Galić <freebsd>
Component: Individual Port(s)Assignee: Alan Somers <asomers>
Status: Closed Works As Intended    
Severity: Affects Only Me Flags: bugzilla: maintainer-feedback? (asomers)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
add groff dependency to fish none

Description Mina Galić freebsd_triage 2023-06-04 22:40:18 UTC 
Created attachment 242602 [details]
add groff dependency to fish

this was reported in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243480
fixed in b0117ef7b455b0fdf5e1d5169c1892cf6093ff1f
and undone in aa7be06e39b1a681cb1b49cbf190d26a75ba630b
Comment 1 Alan Somers freebsd_committer freebsd_triage 2023-06-05 00:30:21 UTC 
The groff dependency was deliberately removed in fish 3.1.0, because upstream changed their man page formatting.  groff is no longer supposed to be necessary.  However, there was a regression upstream, released in fish 3.6.0.
https://github.com/fish-shell/fish-shell/issues/9834

And even when I do install groff, groff prints errors when I try to view the man page, like this:
:grotty:<standard input> (<standard input>):11880: character above first line discarded

Given that upstream doesn't intend for groff to be a dependency, and the man page doesn't even render correctly in groff, I propose that we not add it as a dependency to the port.  Do you agree?
Comment 2 Mina Galić freebsd_triage 2023-06-05 00:33:06 UTC 
after installing groff, fish-doc rendered (not sure if correctly, but it rendered)

this may be an outlier, I didn't check all man pages

but, given upstream's intentions, I think it should suffice to say that this is an upstream bug, and not ours