Bug 271846

Summary: textproc/clucene: apply gentoo patch for C++17 conformance
Product: Ports & Packages Reporter: Dimitry Andric <dim>
Component: Individual Port(s)Assignee: FreeBSD Office Team <office>
Status: Closed FIXED    
Severity: Affects Some People CC: fluffy
Priority: --- Flags: bugzilla: maintainer-feedback? (office)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 271047    
Attachments:
Description Flags
textproc/clucene: apply gentoo patch for C++17 conformance fluffy: maintainer-approval+

Description Dimitry Andric freebsd_committer freebsd_triage 2023-06-05 17:11:30 UTC
Some parts of CLucene use std::binary_function, which was deprecated in
C++11, and has been completely removed as of C++17. This shows up while
building libreoffice with clang >= 16 or gcc >= 11, because C++17 is the
default standard now.

Apply a diff from https://bugs.gentoo.org/869170 that fixes this, by
removing usage of std::binary_function, and replacing it with typedefs.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2023-06-05 17:11:53 UTC
Created attachment 242620 [details]
textproc/clucene: apply gentoo patch for C++17 conformance
Comment 2 Dima Panov freebsd_committer freebsd_triage 2023-06-05 17:24:38 UTC
Comment on attachment 242620 [details]
textproc/clucene: apply gentoo patch for C++17 conformance

Go forward!
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-06-05 20:47:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=36efbbee6de97066e076a994b05dcb076a4ca6c2

commit 36efbbee6de97066e076a994b05dcb076a4ca6c2
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-06-05 17:10:41 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-06-05 20:45:44 +0000

    textproc/clucene: apply gentoo patch for C++17 conformance

    Some parts of CLucene use std::binary_function, which was deprecated in
    C++11, and has been completely removed as of C++17. This shows up while
    building libreoffice with clang >= 16 or gcc >= 11, because C++17 is the
    default standard now.

    Apply a diff from https://bugs.gentoo.org/869170 that fixes this, by
    removing usage of std::binary_function, and replacing it with typedefs.

    PR:             271846
    Approved by:    fluffy (maintainer)
    MFH:            2023Q2

 textproc/clucene/Makefile                          |   2 +-
 .../clucene/files/patch-fix-binary-function (new)  | 147 +++++++++++++++++++++
 2 files changed, 148 insertions(+), 1 deletion(-)