Bug 271894

Summary: net/seaweedfs: Update to 3.52
Product: Ports & Packages Reporter: Boris Korzun <drtr0jan>
Component: Individual Port(s)Assignee: Robert Clausecker <fuz>
Status: Closed FIXED    
Severity: Affects Some People CC: dmgk, fuz
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
seaweedfs.patch drtr0jan: maintainer-approval+

Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2023-06-07 22:32:01 UTC 
The way you fetch the upstream go.mod file is weird.  Check if you can do it the conventional way in a future update.
Comment 2 Boris Korzun 2023-06-08 07:46:29 UTC 
(In reply to Robert Clausecker from comment #1)
Do you mean a ":mod" suffix? I'll remove in a future update.

But if do you mean MASTER_SITES and DISTFILES vars broadly... Unfortunately, seaweedfs project's tags haven't a "v" prefix, so GO_MODULE framework (and proxy.golang.org) doesn't support such tags.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2023-06-08 08:15:14 UTC 
What you can do is download the main project sources normally (with USE_GITHUB) and then build from that, having the go.mk tooling just download the dependencies using module mode.  I'm a bit fuzzy on the details though; dmgk (CC'ed) might be able to point you at a better example.

Another solution is to use a pseudo version for the Go module version.  For example, you can type

    go list -m -f '{{.Version}}' github.com/seaweedfs/seaweedfs@3.52

to get the pseudo version Go uses internally to represent the malformed tag 3.52.  Here I get

    v0.0.0-20230605053426-fb4b61036cd6

You can use this version to fetch the correct Go module as such:

    GO_MODULE= github.com/seaweedfs/seaweedfs@v0.0.0-20230605053426-fb4b61036cd6

This should just work, but I didn't test it.  I'm using a similar approach for devel/go-perf which doesn't have any tagged versions at all.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-06-08 11:36:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=53f2fec64b4116dd970fc18aac7d4a34888798f0

commit 53f2fec64b4116dd970fc18aac7d4a34888798f0
Author:     Boris Korzun <drtr0jan@yandex.ru>
AuthorDate: 2023-06-07 22:24:46 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-06-08 10:51:07 +0000

    net/seaweedfs: update to 3.52

    Changelogs:
    * https://github.com/seaweedfs/seaweedfs/releases/tag/3.48
    * https://github.com/seaweedfs/seaweedfs/releases/tag/3.49
    * https://github.com/seaweedfs/seaweedfs/releases/tag/3.50
    * https://github.com/seaweedfs/seaweedfs/releases/tag/3.51
    * https://github.com/seaweedfs/seaweedfs/releases/tag/3.52

    PR:             271894

 net/seaweedfs/Makefile |  2 +-
 net/seaweedfs/distinfo | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2023-06-08 11:36:16 UTC 
Thank you for your submission.
Comment 6 Boris Korzun 2023-12-08 07:36:09 UTC 
(In reply to Robert Clausecker from comment #3)
Fixed in bug #275609. Thx.