Bug 271914
| Summary: | graphics/qt5-imageformats: fix build with clang 16 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dimitry Andric <dim> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-kde (group) <kde> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | tcberner | ||||
| Priority: | --- | Flags: | tcberner:
maintainer-feedback+
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 271047 | ||||||
| Attachments: |
|
||||||
Created attachment 242693 [details]
graphics/qt5-imageformats: fix build with clang 16
Moin moin Thanks! ship it. mfg Tobias A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7393af6f4fbab56776eac34830eb81dd7d391f07 commit 7393af6f4fbab56776eac34830eb81dd7d391f07 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2023-06-08 17:48:04 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2023-06-11 16:15:58 +0000 graphics/qt5-imageformats: fix build with clang 16 Since clang 16 (and gcc 11) the default C++ standard is now gnu++17. Because graphics/qt5-imageformats 's build infrastructure does not explicitly set its C++ standard, this leads to an issue detecting libmng in the configure stage: Configure summary: Further Image Formats: JasPer ................................. yes MNG .................................... no TIFF ................................... yes Using system libtiff ................. yes WEBP ................................... yes Using system libwebp ................. yes This is because the small configure test program for libmng includes libmng.h, which transitively includes lcms.h, and the latter fails due to 'register' keywords in the header. With lcms2.h there is a special define CMS_NO_REGISTER_KEYWORD to avoid usage of the register keyword, but lcms.h is very old and does not support that. As a workaround, define the register keyword away via a "head" object in src/imageformats/configure.json, and via CXXFLAGS for the rest of the build. PR: 271914 Approved by: tcberner (maintainer) MFH: 2023Q2 graphics/qt5-imageformats/Makefile | 4 +++- .../files/patch-src_imageformats_configure.json | 12 +++++++++++- 2 files changed, 14 insertions(+), 2 deletions(-) |
Since clang 16 (and gcc 11) the default C++ standard is now gnu++17. Because graphics/qt5-imageformats 's build infrastructure does not explicitly set its C++ standard, this leads to an issue detecting libmng in the configure stage: Configure summary: Further Image Formats: JasPer ................................. yes MNG .................................... no TIFF ................................... yes Using system libtiff ................. yes WEBP ................................... yes Using system libwebp ................. yes This is because the small configure test program for libmng includes libmng.h, which transitively includes lcms.h, and the latter fails due to 'register' keywords in the header. With lcms2.h there is a special define CMS_NO_REGISTER_KEYWORD to avoid usage of the register keyword, but lcms.h is very old and does not support that. As a workaround, define the register keyword away via a "head" object in src/imageformats/configure.json, and via CXXFLAGS for the rest of the build.